feat: refactor usages of chain selectors API to use remote API#614
feat: refactor usages of chain selectors API to use remote API#614
Conversation
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
|
|
|
||
| // TODO: passing this as param requires a breaking change to the Encoder interfaces | ||
| // which requires changes too all chain specific SDKs. Consider refactoring later. | ||
| evmChainID, err := getEVMChainID(context.Background(), e.ChainSelector, e.IsSim) |
There was a problem hiding this comment.
I want to remove this context.Background() and pass it as a param. But doing so will mean modifying the interfaces on the sdk pkg which is a pretty significant breaking change. My proposal is to go with this suboptimal approach so we can get the benefits of the remote apis now, and work on adding the ctx as separate followup so we can scope all breaking changes in a single PR and document better the changes that product teams would need to do for announcements, etc.
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Notes:
context.Backgroundthat I had to hardcode in the evm sdk. This is because we still need to provide actxvariable at the interface level, which would mean a breaking change is introduced and all chain families sdk would need to be updated. I'd prefer to leave that for a separate PR.