Skip to content

ci: adds missing permissions to workflows #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jkongie wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: adds missing permissions to workflows #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/pull-request-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ jobs:

ci-sonarqube:
name: Sonarqube Scan
needs: [ ci-lint, ci-lint-misc, ci-test ]
needs: [ci-lint, ci-lint-misc, ci-test]
runs-on: ubuntu-latest
permissions:
contents: read
if: github.actor != 'dependabot[bot]'
steps:
- name: Scanning with Sonarqube
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/push-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ jobs:
name: Lint
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
actions: read
steps:
- name: Linting Go
uses: smartcontractkit/.github/actions/ci-lint-go@bd2ca3d8fa2dc89f98b49b297e9b72c2e3e68cdc # ci-lint-go@3.1.0
Expand All @@ -26,9 +24,7 @@ jobs:
name: Lint E2E tests
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
actions: read
steps:
- name: Linting Go
uses: smartcontractkit/.github/actions/ci-lint-go@bd2ca3d8fa2dc89f98b49b297e9b72c2e3e68cdc # ci-lint-go@3.1.0
Expand All @@ -54,7 +50,7 @@ jobs:
actions: read
steps:
- name: ci-test
uses: smartcontractkit/.github/actions/ci-test-go@ci-test-go/1.0.0
uses: smartcontractkit/.github/actions/ci-test-go@dfcba48f05933158428bce867d790e3d5a9baa6b # ci-test-go@1.1.0
with:
go-test-cmd: go test -coverprofile=coverage.txt $(go list ./...)
use-go-cache: true
Expand Down Expand Up @@ -147,7 +143,6 @@ jobs:
exit 0
}


cd-release:
runs-on: ubuntu-latest
permissions:
Expand All @@ -167,7 +162,7 @@ jobs:

ci-sonarqube:
name: Sonarqube Scan
needs: [ ci-lint, ci-lint-misc, ci-test ]
needs: [ci-lint, ci-lint-misc, ci-test]
runs-on: ubuntu-latest
if: github.actor != 'dependabot[bot]'
steps:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/push-tag-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
update-git-tag: "true"
# goreleaser inputs
goreleaser-args: "--config .goreleaser.yml"
goreleaser-version: '~> v2'
goreleaser-version: "~> v2"
goreleaser-dist: goreleaser-pro
goreleaser-key: ${{ secrets.GORELEASER_KEY }}

Expand All @@ -69,6 +69,8 @@ jobs:
needs:
- cicd-publish-release
runs-on: ubuntu-latest
permissions:
contents: read
environment: build-publish
steps:
- name: Checkout repository
Expand All @@ -85,4 +87,4 @@ jobs:
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN_RELENG }} # Releng Bot
git-ref: ${{ env.TAG }}
git-ref-type: tag
changelog-url: 'https://github.com/${{ github.repository }}/releases/tag/${{ env.TAG }}'
changelog-url: "https://github.com/${{ github.repository }}/releases/tag/${{ env.TAG }}"
Loading