Data Streams: remove verifier fee from samples and warn in schema#3993
Open
dev-dist wants to merge 3 commits into
Open
Data Streams: remove verifier fee from samples and warn in schema#3993dev-dist wants to merge 3 commits into
dev-dist wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
👋 dev-dist, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cl-mayowa
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Data Streams sample contracts to remove legacy fee handling logic and interfaces, reflecting the switch to subscription-based billing. The main changes are the removal of all FeeManager-related code, documentation updates to clarify that LINK approvals and fee quoting are no longer required, and simplification of the report verification process.
Fee handling removal and simplification:
FeeManager,RewardManager, and LINK/ERC20 approvals have been removed fromClientReportsVerifier.sol,StreamsUpkeep.sol, andStreamsUpkeepRegistrar.sol. [1] [2] [3] [4] [5]VerifierProxy.verify()orverifyBulk()with empty bytes for the parameter payload, as subscription billing does not require fee metadata or approvals. [1] [2] [3]Documentation and comments:
nativeFeeandlinkFeein report structs have been updated to indicate these are legacy fields and not used for subscription billing. [1] [2] [3] [4]Interface and code cleanup:
IFeeManagerinterface and related methods have been removed from all sample contracts. [1] [2] [3]FEE_ADDRESS) have been deleted. [1] [2]These changes make the sample contracts easier to understand and use, aligning them with the current Data Streams billing model.