Skip to content

Data Streams: remove verifier fee from samples and warn in schema#3993

Open
dev-dist wants to merge 3 commits into
mainfrom
data-streams-noop-fee
Open

Data Streams: remove verifier fee from samples and warn in schema#3993
dev-dist wants to merge 3 commits into
mainfrom
data-streams-noop-fee

Conversation

@dev-dist

Copy link
Copy Markdown
Collaborator

This pull request updates the Data Streams sample contracts to remove legacy fee handling logic and interfaces, reflecting the switch to subscription-based billing. The main changes are the removal of all FeeManager-related code, documentation updates to clarify that LINK approvals and fee quoting are no longer required, and simplification of the report verification process.

Fee handling removal and simplification:

  • All imports, interface definitions, and code related to FeeManager, RewardManager, and LINK/ERC20 approvals have been removed from ClientReportsVerifier.sol, StreamsUpkeep.sol, and StreamsUpkeepRegistrar.sol. [1] [2] [3] [4] [5]
  • The report verification process now directly calls VerifierProxy.verify() or verifyBulk() with empty bytes for the parameter payload, as subscription billing does not require fee metadata or approvals. [1] [2] [3]

Documentation and comments:

  • All comments and docstrings have been updated to clarify that Data Streams uses subscription-based billing, and that no LINK tokens or fee approvals are required for verification calls. [1] [2] [3] [4] [5] [6]
  • Field comments for nativeFee and linkFee in report structs have been updated to indicate these are legacy fields and not used for subscription billing. [1] [2] [3] [4]

Interface and code cleanup:

  • The custom IFeeManager interface and related methods have been removed from all sample contracts. [1] [2] [3]
  • Unused state variables related to fee management (e.g., FEE_ADDRESS) have been deleted. [1] [2]

These changes make the sample contracts easier to understand and use, aligning them with the current Data Streams billing model.

@dev-dist
dev-dist requested review from a team as code owners July 23, 2026 15:25
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
documentation Ready Ready Preview Jul 23, 2026 10:05pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

👋 dev-dist, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants