feat(mcms): add Solana deploy changeset for MCMS with timelock [CLD-2719] by graham-chainlink · Pull Request #108 · smartcontractkit/cld-changesets

graham-chainlink · 2026-06-26T05:53:44Z

Adds a Solana chain-family implementation for the deploy MCMS changeset

github-actions · 2026-06-26T05:54:00Z

Release impact (release-please)


Current version	`0.7.1` (on `main`)
After merge	`0.8.0` (minor bump)

PR title: feat(mcms): add Solana deploy changeset for MCMS with timelock [CLD-2719]

Merging this PR as-is will contribute a minor bump to the next release-please release PR.

Conventional commit → bump

Intent	PR title prefix	Bump
Bug fix	`fix:`	patch
New feature	`feat:`	minor
Breaking change	`feat!:` / `fix!:` or `BREAKING CHANGE:` / `BREAKING-CHANGE:` in description	major
No release	`chore:`, `docs:`, `ci:`, `refactor:`, etc.	none

Update the PR title before merge if you need a different bump (squash commit message = PR title).

Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on main.

Copilot

Pull request overview

Adds a Solana chain-family implementation of the MCMS “deploy with timelock” changeset, wiring it into the shared deploy registry and providing Solana operations + sequencing to deploy programs, initialize accounts/instances, and grant timelock roles.

Changes:

Introduces a Solana deploy sequence that deploys/initializes AccessController, MCM instances, and Timelock, then configures role grants.
Adds Solana-specific operations (deploy program, init AC account, init MCM instance, init timelock instance, setup roles) with idempotency handling.
Adds Solana integration tests covering fresh and partial deployments.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
mcms/solana/deploy/sequence.go	Orchestrates the end-to-end Solana MCMS+timelock deployment flow and output metadata collection.
mcms/solana/deploy/operations.go	Implements Solana operations for deploying programs, initializing accounts/instances, and granting roles.
mcms/solana/deploy/register.go	Registers the Solana family implementation in the shared deploy registry and validates chain presence.
mcms/solana/deploy/idempotency.go	Adds chain-scoped idempotency key helper for operation caching.
mcms/solana/deploy/changeset_test.go	Solana integration tests for fresh deploy and partial deploy behavior.
mcms/solana/deploy/addresses.go	Loads existing deployed Solana addresses/seeds from the datastore with version/qualifier filtering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

graham-chainlink · 2026-06-26T10:14:40Z

+	mcmscontracts "github.com/smartcontractkit/chainlink-deployments-framework/engine/cld/contracts/mcms"
+
+	"github.com/smartcontractkit/cld-changesets/internal/semvers"
+	legacysolana "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana"


this has to use some of the legacy code, but i think those are useful, considering to move them out of legacy pkg after this PR is merged

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

graham-chainlink · 2026-06-26T10:37:34Z

 ) (common.Address, bool) {
-	baseFilters := make([]cldfdatastore.FilterFunc[cldfdatastore.AddressRefKey, cldfdatastore.AddressRef], 0, 3)
-	baseFilters = append(baseFilters,
+	version := semvers.V1_0_0


hardcoded version to be 1 for now, ideally user should specify the version they want (proposal util timelock config struct does not contain version field currently)

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

cl-sonarqube-production · 2026-06-26T11:18:50Z

Quality Gate failed

Failed conditions
71.9% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

ecPablo · 2026-06-26T13:53:27Z

 	return refs
 }
+
+type fakeDataStore struct {


nit: we could use mockery to get a datastore mock and save ourselves a bit of code

For simple use case, i prefer using stubs but i see your point about the duplication, so i ended moving the stub into internal/testutil so it can be reused, have a look.

ecPablo · 2026-06-26T13:58:44Z

+// opSetupTimelockRoles grants proposer/executor/canceller/bypasser roles on the timelock.
+var opSetupTimelockRoles = operations.NewOperation(
+	"sol-setup-timelock-roles",
+	semver.MustParse("1.0.0"),
+	"Grant MCMS signer PDAs their roles on the Solana timelock",


Thinking if we should move this togrant-roles/ folder... I have a WIP adding the evm implementation here #104, solana is still pending but a portion of this might be used for the grant-role solana logic. Maybe not exactly the same since grant-role should allow arbitrary contracts and not force the specific

grants := []roleGrant{ {timelockBindings.Proposer_Role, []solanago.PublicKey{proposerPDA}, in.ProposerAC}, {timelockBindings.Executor_Role, []solanago.PublicKey{chain.DeployerKey.PublicKey()}, in.ExecutorAC}, {timelockBindings.Canceller_Role, []solanago.PublicKey{cancellerPDA, proposerPDA, bypasserPDA}, in.CancellerAC}, {timelockBindings.Bypasser_Role, []solanago.PublicKey{bypasserPDA}, in.BypasserAC}, }

structure used for the standard topology

i see, once your solana PR goes in, i can update this to use the operation over there then? Same for EVM

ecPablo · 2026-06-26T14:00:02Z

+	"github.com/stretchr/testify/require"
+)
+
+func TestTimelockMinDelayUint64(t *testing.T) {


Should we add tests for each of the operations logic? just asserting the individual ixs are what we expect?

I added more coverage on the integration tests instead of more unit test as i can test the end results.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

…719] Register Solana in the MCMS deploy registry with an operations-based sequence that deploys programs, initializes accounts/instances, and grants timelock roles, matching the EVM deploy pattern.

graham-chainlink requested a review from Copilot June 26, 2026 05:53

Copilot started reviewing on behalf of graham-chainlink June 26, 2026 05:54 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread mcms/solana/deploy/operations.go

Comment thread mcms/solana/deploy/operations.go Outdated

Comment thread mcms/solana/deploy/sequence.go Outdated

Comment thread mcms/solana/deploy/sequence.go Outdated

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 5d4c0ad to 74276e1 Compare June 26, 2026 06:14

graham-chainlink requested a review from Copilot June 26, 2026 06:15

Copilot started reviewing on behalf of graham-chainlink June 26, 2026 06:15 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread mcms/solana/deploy/operations.go Outdated

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 74276e1 to f79f36c Compare June 26, 2026 10:13

graham-chainlink requested a review from Copilot June 26, 2026 10:13

Copilot started reviewing on behalf of graham-chainlink June 26, 2026 10:14 View session

graham-chainlink commented Jun 26, 2026

View reviewed changes

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread mcms/solana/deploy/operations.go Outdated

Comment thread mcms/solana/deploy/operations.go

Comment thread mcms/solana/deploy/addresses.go Outdated

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from f79f36c to 4251a75 Compare June 26, 2026 10:36

graham-chainlink requested a review from Copilot June 26, 2026 10:36

Copilot started reviewing on behalf of graham-chainlink June 26, 2026 10:37 View session

graham-chainlink commented Jun 26, 2026

View reviewed changes

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread mcms/solana/deploy/idempotency.go

Comment thread mcms/solana/deploy/addresses.go Outdated

Comment thread mcms/evm/deploy/addresses.go Outdated

Comment thread mcms/evm/deploy/addresses.go

graham-chainlink marked this pull request as ready for review June 26, 2026 10:59

graham-chainlink requested a review from a team as a code owner June 26, 2026 10:59

product-security-plaid-production Bot requested a review from DimitriosNaikopoulos June 26, 2026 11:00

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 4251a75 to 61ad06b Compare June 26, 2026 11:00

graham-chainlink requested a review from Copilot June 26, 2026 11:00

Copilot started reviewing on behalf of graham-chainlink June 26, 2026 11:00 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread mcms/solana/deploy/changeset_test.go Outdated

Comment thread mcms/solana/deploy/sequence.go Outdated

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 61ad06b to 97025bc Compare June 26, 2026 11:11

graham-chainlink requested a review from ecPablo June 26, 2026 11:14

graham-chainlink commented Jun 26, 2026

View reviewed changes

Comment thread mcms/solana/deploy/operations.go

ecPablo previously approved these changes Jun 26, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 29, 2026 06:02

graham-chainlink dismissed ecPablo’s stale review via 64f6019 June 29, 2026 06:02

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 97025bc to 64f6019 Compare June 29, 2026 06:02

Copilot started reviewing on behalf of graham-chainlink June 29, 2026 06:02 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread mcms/solana/deploy/addresses.go

Comment thread mcms/solana/deploy/addresses.go

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 64f6019 to 0408440 Compare June 29, 2026 06:22

graham-chainlink requested review from Copilot and ecPablo June 29, 2026 06:22

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from 0408440 to efee063 Compare June 29, 2026 12:07

Copilot started reviewing on behalf of graham-chainlink June 29, 2026 12:08 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread mcms/solana/deploy/operations.go

feat(mcms): add Solana deploy changeset for MCMS with timelock [CLD-2…

e9a713b

…719] Register Solana in the MCMS deploy registry with an operations-based sequence that deploys programs, initializes accounts/instances, and grants timelock roles, matching the EVM deploy pattern.

graham-chainlink force-pushed the ggoh/CLD-2719/solana-mcms-deploy branch from efee063 to e9a713b Compare June 29, 2026 12:25

graham-chainlink mentioned this pull request Jun 29, 2026

[NOT READY]tests: replace legacy changeset usage with new #110

Open

ecPablo approved these changes Jun 29, 2026

View reviewed changes

Uh oh!

Conversation

graham-chainlink commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026

Release impact (release-please)

Conventional commit → bump

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

graham-chainlink Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graham-chainlink Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cl-sonarqube-production Bot commented Jun 26, 2026

Quality Gate failed

Uh oh!

ecPablo Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

graham-chainlink Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ecPablo Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

graham-chainlink Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ecPablo Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

graham-chainlink Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

graham-chainlink commented Jun 26, 2026 •

edited

Loading

graham-chainlink Jun 26, 2026 •

edited

Loading

graham-chainlink Jun 29, 2026 •

edited

Loading