Added gas shifting from billing service provided values - #23393
Added gas shifting from billing service provided values#23393russell-stern wants to merge 2 commits into
Conversation
|
👋 russell-stern, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
|
I see you updated files related to
|
|
| } | ||
|
|
||
| report.rateCard, err = toRateCard(resp) | ||
| report.rateCard, report.gasPrecision, err = toRateCard(resp) |
There was a problem hiding this comment.
report.rateCard and report.gasPrecision are initialized above, and here they are overwritten with the toRateCard result. In case of error, gasPrecision is set to nil, but later it's accessed as if it was initialized.
|
|
||
| // default to 18 (EVM) if not provided by the billing service. | ||
| // a value of 0 means the capability already emits fixed-point integers and no shift is needed. | ||
| precision := uint32(18) |
There was a problem hiding this comment.
It does not seem safe to use 18 as the default if we do not have a value.
If an error occurred during fetching the map will be nil.
Or even worse resp will be nil
3 participants
No description provided.