Skip to content

[CRE] Remove obsolete v1 logic from Launcher - #23362

Draft
bolekk wants to merge 1 commit into
developfrom
keystone_cleanup_4
Draft

[CRE] Remove obsolete v1 logic from Launcher#23362
bolekk wants to merge 1 commit into
developfrom
keystone_cleanup_4

Conversation

@bolekk

@bolekk bolekk commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

👋 bolekk, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production

Copy link
Copy Markdown

@trunk-io

trunk-io Bot commented Aug 8, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestLauncher/NOK-invalid_trigger_capability The test failed because the expected number of capability DONs was not found, indicating a mismatch in the capability setup or registration. Logs ↗︎
TestLauncher_OnNewRegistry_CallsLocalCapabilityManagerReconcile The test failed because a required capability method configuration was nil, causing a call to not be made. Logs ↗︎
TestLauncher The test named 'TestLauncher' failed to complete successfully. Logs ↗︎
TestLauncher_SucceedsEvenIfDispatcherAlreadyHasReceiver The test failed because the expected call to SetReceiver was not made. Logs ↗︎

... and 7 more

View Full Report ↗︎Docs

@bolekk
bolekk marked this pull request as draft August 8, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants