switch post-build-publish to use workflow dispatch instead of reposit…#22381
Open
Tofel wants to merge 1 commit into
Open
switch post-build-publish to use workflow dispatch instead of reposit…#22381Tofel wants to merge 1 commit into
Tofel wants to merge 1 commit into
Conversation
product-security-plaid-production
Bot
requested review from
RensR,
chainchad and
ecPablo
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR updates the release automation so post-build-publish.yml is triggered via workflow_dispatch (run from the tag ref) instead of repository_dispatch, preventing runs from inadvertently using develop’s workflow definitions when operating on a tag.
Changes:
- Switched
.github/workflows/post-build-publish.ymlfromrepository_dispatchtoworkflow_dispatchwith explicit inputs. - Updated
.github/workflows/build-publish.ymlto triggerpost-build-publish.ymlviagh workflow run --ref <tag>and added a pre-flight workflow existence check.
Scrupulous human review recommended (high impact areas):
- The new
gh workflow view/gh workflow runlogic and its error-handling/skip behavior in.github/workflows/build-publish.yml. - Input validation behavior changes in
.github/workflows/post-build-publish.yml(especially around empty/invalid inputs).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/post-build-publish.yml | Replaces repository_dispatch trigger with workflow_dispatch inputs and updates payload references accordingly. |
| .github/workflows/build-publish.yml | Replaces repository dispatch emission with a gh workflow run dispatch against the pushed tag ref. |
Tofel
force-pushed
the
switch_repository_dispatch_to_workflow_dispatch
branch
from
0605a1d to
1cdce15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ory dispatch to avoid this kind of issues where the triggered workflow runs from
developbranch that uses a reusable workflow that doesn't yet exists in the tag that we checkout.