Skip to content

Remove vrf v1#22380

Draft
RensR wants to merge 4 commits into
developfrom
remove-vrf-v1
Draft

Remove vrf v1#22380
RensR wants to merge 4 commits into
developfrom
remove-vrf-v1

Conversation

@RensR
Copy link
Copy Markdown
Contributor

@RensR RensR commented May 11, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 4 @smartcontractkit/foundations, @smartcontractkit/core
/.changeset/ 1 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/job/ 2 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/pipeline/ 4 @smartcontractkit/foundations, @smartcontractkit/bix-framework, @smartcontractkit/core
/core/services/vrf/ 26 @smartcontractkit/dev-services, @smartcontractkit/core
/core/services/blockhashstore/ 6 @smartcontractkit/dev-services, @smartcontractkit/core
/core/services/blockheaderfeeder/ 3 @smartcontractkit/dev-services, @smartcontractkit/core
/core/services/pipeline/task.vrf.go 1 @smartcontractkit/dev-services
/core/scripts/vrf*/ 2 @smartcontractkit/dev-services
/core/web/resolver/ 2 @smartcontractkit/foundations, @smartcontractkit/core
/devenv/ 7 @smartcontractkit/devex-tooling
/deployment/ 1 @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/operations-platform, @smartcontractkit/core
/.github/** 1 @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 11, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestJobController_Create_HappyPath The test failed without a specific error message, indicating an unspecified failure during execution. Logs ↗︎
Test_CheckFromAddressMaxGasPrices The test failed because an unexpected method call to PriceMaxKey was made without a predefined mock response. Logs ↗︎
Test_CheckFromAddressMaxGasPrices/returns_nil_error_if_gasLanePrice_not_set_in_job_spec The test failed due to a panic or call to FailNow within a subtest, which caused the test to terminate unexpectedly. Logs ↗︎
TestJobController_Create_HappyPath/vrf The test failed due to a panic or runtime exit during execution, indicating an unexpected error or failure in the test process. Logs ↗︎

... and 2 more

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant