Conversation
…ion in workflow load test
Contributor
|
✅ No conflicts with other open PRs targeting |
|
chudilka1
approved these changes
May 11, 2026
jmank88
requested changes
May 11, 2026
Comment on lines
+499
to
+506
| // Poll until the capability has received at least one request, confirming | ||
| // the report has been generated and the capability is ready. | ||
| select { | ||
| case <-receiveChannel: | ||
| testLogger.Info().Msg("Capability report generated and ready") | ||
| default: | ||
| time.Sleep(time.Second * 5) // fallback: wait briefly then proceed | ||
| } |
Contributor
There was a problem hiding this comment.
Isn't this meant to be polling in a loop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After hooking into mock executable capabilities, the test used a fixed
5-second sleep to wait for the report to be generated before starting
the load test. This is fragile: report generation may take longer under
load, causing false test failures, or complete sooner, wasting time.
Replace the sleep with a polling loop that checks whether the capability
has received its first request on the channel, confirming the report is
ready. The polling uses a 30-second timeout with 1-second intervals.
cre-4229