Skip to content

cre-4228: devenv: replace sleep with polling for upkeep completion in…#22377

Open
mchain0 wants to merge 5 commits into
developfrom
cre-4228
Open

cre-4228: devenv: replace sleep with polling for upkeep completion in…#22377
mchain0 wants to merge 5 commits into
developfrom
cre-4228

Conversation

@mchain0
Copy link
Copy Markdown
Contributor

@mchain0 mchain0 commented May 11, 2026

After load generators finish, the test used a fixed 60-second sleep
(StopWaitTime) to wait for upkeeps to be performed before collecting
metrics. This is wasteful when upkeeps complete faster, and may be
insufficient under heavy load.

Replace the sleep with an Eventually block that polls each consumer
contract to verify the upkeep counter has increased past the pre-load
baseline, confirming the upkeeps have been executed. The polling uses a
5-minute timeout with 5-second intervals.

cre-4228

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 11, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@mchain0 mchain0 marked this pull request as ready for review May 11, 2026 13:32
@mchain0 mchain0 requested a review from a team as a code owner May 11, 2026 13:32
chudilka1
chudilka1 previously approved these changes May 11, 2026
MStreet3
MStreet3 previously approved these changes May 11, 2026
Comment thread devenv/tests/automation/load_test.go Outdated
Comment thread devenv/tests/automation/load_test.go Outdated
Co-authored-by: Jordan Krage <jmank88@gmail.com>
@mchain0 mchain0 dismissed stale reviews from MStreet3 and chudilka1 via 988013a May 11, 2026 13:58
Co-authored-by: Jordan Krage <jmank88@gmail.com>
@mchain0 mchain0 requested review from MStreet3, chudilka1 and jmank88 May 11, 2026 14:03
@cl-sonarqube-production
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants