Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
chudilka1
approved these changes
May 11, 2026
MStreet3
approved these changes
May 11, 2026
Tofel
reviewed
May 11, 2026
| return block, err | ||
| }, time.Minute*2, time.Second*2).Should(gomega.BeNumerically(">", preRestartBlock), | ||
| "Node %d should be processing new blocks after restart", i) | ||
| l.Info().Msgf("Node %d is ready after upgrade", i) |
Contributor
There was a problem hiding this comment.
but this chain client has nothing to do with the node... it's a standalone Ethereum client that connects to the RPC
Contributor
Author
There was a problem hiding this comment.
how else would you remove the sleep?
Tofel
requested changes
May 11, 2026
Contributor
Tofel
left a comment
Tofel
left a comment
There was a problem hiding this comment.
a.ChainClient has nothing to do with the node... it's a standalone Ethereum client that connects to the RPC. It is literally a chain client, and chain is not a shortcut for chainlink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After restarting nodes during a rolling upgrade, the test used a fixed
10-second sleep before checking upkeep counters. This is fragile: nodes
may take longer to become ready, wasting CI time, or may be ready sooner,
making the test unnecessarily slow.
Replace the sleep with an
Eventuallyblock that polls the chain clientto confirm the node has processed new blocks, indicating readiness. The
polling uses a 2-minute timeout with 2-second intervals, which is
consistent with the existing
UpkeepExecutionTimeoutpattern in the samefile.
cre-4227