Skip to content

[DX-4035] streamline ci deployment#22372

Open
Tofel wants to merge 3 commits into
developfrom
dx-4035-streamline-ci-deployment
Open

[DX-4035] streamline ci deployment#22372
Tofel wants to merge 3 commits into
developfrom
dx-4035-streamline-ci-deployment

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented May 11, 2026

According to @erikburt comments

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 11, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@Tofel Tofel marked this pull request as ready for review May 11, 2026 10:34
@Tofel Tofel requested a review from a team as a code owner May 11, 2026 10:34
Copilot AI review requested due to automatic review settings May 11, 2026 10:34
@Tofel Tofel requested review from a team as code owners May 11, 2026 10:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM — CI workflow changes can inadvertently skip important test coverage or increase CI load/costs, impacting reliability of merges and releases.

This PR simplifies the ci-deployments GitHub Actions workflow by removing unused module-detection / scheduling frequency logic and tightening parts of the deployment-test trigger configuration.

Changes:

  • Removed the changed-modules step/output and the run-frequency job from the workflow.
  • Simplified the advanced-triggers file-set configuration for the deployment-tests trigger.
  • Updated the Go build cache version to include the shard index to avoid cross-shard cache sharing.

Scrupulous human review recommended:

  • The advanced-triggers file-sets / triggers logic (to ensure it still reflects the intended “what changes should trigger deployment tests” policy).
  • The caching change (build-cache-version) to confirm it’s the desired tradeoff (cache correctness vs. cache hit rate / storage).

Comment thread .github/workflows/ci-deployments.yml
@Tofel Tofel force-pushed the dx-4035-streamline-ci-deployment branch from 02a26c0 to 5e10968 Compare May 11, 2026 11:39
@Tofel Tofel requested a review from Copilot May 11, 2026 12:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants