[DX-4035] streamline ci deployment#22372
Open
Tofel wants to merge 3 commits into
Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — CI workflow changes can inadvertently skip important test coverage or increase CI load/costs, impacting reliability of merges and releases.
This PR simplifies the ci-deployments GitHub Actions workflow by removing unused module-detection / scheduling frequency logic and tightening parts of the deployment-test trigger configuration.
Changes:
- Removed the
changed-modulesstep/output and therun-frequencyjob from the workflow. - Simplified the
advanced-triggersfile-set configuration for thedeployment-teststrigger. - Updated the Go build cache version to include the shard index to avoid cross-shard cache sharing.
Scrupulous human review recommended:
- The
advanced-triggersfile-sets/triggerslogic (to ensure it still reflects the intended “what changes should trigger deployment tests” policy). - The caching change (
build-cache-version) to confirm it’s the desired tradeoff (cache correctness vs. cache hit rate / storage).
02a26c0 to
5e10968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to @erikburt comments