Vault capability advanced metrics#22354
Open
prashantkumar1982 wants to merge 14 commits into
Open
Conversation
- Gate pending-queue reads in Observation and ValidateObservation when VaultForceEmptyOCRRounds is enabled; rename batch to currentPendingQueueItems and remove redundant GetPendingQueue call - Add VaultForceEmptyOCRRounds GateLimiter to reporting plugin config; Close() and test helper wiring - Resolve OCR plugin limits via BoundLimiter.Limit() in initializePluginLimits; extract helpers to plugin_utils.go (resolveVaultOCRBoundLimitInt, logging for forceEmptyOCRRounds) Co-authored-by: Cursor <cursoragent@cursor.com>
… into feat/vault-force-empty-ocr-rounds
Track per-request timestamps and seqNrs from capability.handleRequest through Observation, StateTransition, and Transmit, emitting OTLP latency and round delta metrics plus outcome counters for success, timeout, and response errors. Add platform_vault_plugin_local_queue_size histogram on each Observation for the local request store size. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
product-security-plaid-production
Bot
requested review from
ettec and
justinkaseman
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
… into feat/vault-force-empty-ocr-rounds
… into feat/vault-capability-advanced-metrics
… into feat/vault-capability-advanced-metrics
… into feat/vault-capability-advanced-metrics
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…m/smartcontractkit/chainlink into feat/vault-capability-advanced-metrics
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
prashantkumar1982
changed the title
jmank88
reviewed
May 9, 2026
Comment on lines
+40
to
+46
| limiter, err := limits.MakeUpperBoundLimiter(factory, spec) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("%s: %w", settingKey, err) | ||
| } | ||
| defer func() { _ = limiter.Close() }() | ||
|
|
||
| v, err := limiter.Limit(ctx) |
Contributor
There was a problem hiding this comment.
No need to construct a limiter to just do a lookup:
Suggested change
| limiter, err := limits.MakeUpperBoundLimiter(factory, spec) | |
| if err != nil { | |
| return 0, fmt.Errorf("%s: %w", settingKey, err) | |
| } | |
| defer func() { _ = limiter.Close() }() | |
| v, err := limiter.Limit(ctx) | |
| v, err := spec.GetOrDefault(ctx, factory.Settings) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds observability for the Vault capability and OCR reporting plugin: per-request lifecycle timestamps and seqNrs from
Capability.handleRequestthrough blob broadcast, pending queue writes, observation batch processing, state transition outcomes, and transmit, through successful capability response or timeout.Also records
platform_vault_plugin_local_queue_sizeon each Observation.Metrics
success|timeout|response_errorImplementation notes
delegate.gointo capability, reporting plugin factory, and transmitter.-1when unset.Tickets:
https://smartcontract-it.atlassian.net/browse/CRE-3517
https://smartcontract-it.atlassian.net/browse/CRE-4072