Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM (deployment-time behavior changes for capability registry configuration; relies on Job Distributor metadata and config marshaling)
This PR aims to support Aptos capabilities in the Capabilities Registry v2 “add-capabilities” flow by injecting an Aptos p2pToTransmitterMap into specConfig, derived from Job Distributor node metadata.
Changes:
- Adds Aptos helpers to parse an Aptos capability ID and to build/merge
p2pToTransmitterMapinto capability config (specConfig). - Introduces (currently commented-out) scaffolding in the add-capabilities sequence intended to perform the Aptos config injection.
- Adds an integration test asserting the Aptos capability config contains
specConfig.p2pToTransmitterMap.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
deployment/cre/capabilities_registry/v2/changeset/sequences/aptos_capability_config.go |
New helpers for Aptos capability ID parsing and building/merging p2pToTransmitterMap into specConfig. |
deployment/cre/capabilities_registry/v2/changeset/sequences/add_capabilities.go |
Adds (commented-out) intended injection logic in the add-capabilities sequence. |
deployment/cre/capabilities_registry/v2/changeset/add_capabilities_test.go |
Adds an Aptos-focused integration test that expects p2pToTransmitterMap to be present on-chain. |
Scrupulous human review areas:
- The end-to-end injection point in the add-capabilities sequence (must be per-DON, and must not accidentally mutate shared
CapabilityConfigsacross DON iterations). - Correctness of the Job Distributor → on-chain config mapping (ensuring no missing nodes lead to partial configs).
Suggested reviewers (per .github/CODEOWNERS for /deployment/cre):
@smartcontractkit/keystone@smartcontractkit/operations-platform
deployment/cre/capabilities_registry/v2/changeset/sequences/add_capabilities.go
Outdated
Show resolved
Hide resolved
deployment/cre/capabilities_registry/v2/changeset/sequences/aptos_capability_config.go
Show resolved
Hide resolved
|




Uh oh!
There was an error while loading. Please reload this page.