Skip to content

Aptos p2p map to cap reg#21668

Draft
yashnevatia wants to merge 3 commits intodevelopfrom
aptos-p2p-map-to-capReg
Draft

Aptos p2p map to cap reg#21668
yashnevatia wants to merge 3 commits intodevelopfrom
aptos-p2p-map-to-capReg

Conversation

@yashnevatia
Copy link
Contributor

@yashnevatia yashnevatia commented Mar 24, 2026

  • Create p2pIdToTransmitter mapping for aptos capabilities
  • Add it in CapabilityConfig.SpecConfig["p2pToTransmitterMap"]

@yashnevatia yashnevatia requested review from a team as code owners March 24, 2026 15:42
Copilot AI review requested due to automatic review settings March 24, 2026 15:42
@github-actions
Copy link
Contributor

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

✅ No conflicts with other open PRs targeting develop

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM (deployment-time behavior changes for capability registry configuration; relies on Job Distributor metadata and config marshaling)

This PR aims to support Aptos capabilities in the Capabilities Registry v2 “add-capabilities” flow by injecting an Aptos p2pToTransmitterMap into specConfig, derived from Job Distributor node metadata.

Changes:

  • Adds Aptos helpers to parse an Aptos capability ID and to build/merge p2pToTransmitterMap into capability config (specConfig).
  • Introduces (currently commented-out) scaffolding in the add-capabilities sequence intended to perform the Aptos config injection.
  • Adds an integration test asserting the Aptos capability config contains specConfig.p2pToTransmitterMap.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
deployment/cre/capabilities_registry/v2/changeset/sequences/aptos_capability_config.go New helpers for Aptos capability ID parsing and building/merging p2pToTransmitterMap into specConfig.
deployment/cre/capabilities_registry/v2/changeset/sequences/add_capabilities.go Adds (commented-out) intended injection logic in the add-capabilities sequence.
deployment/cre/capabilities_registry/v2/changeset/add_capabilities_test.go Adds an Aptos-focused integration test that expects p2pToTransmitterMap to be present on-chain.

Scrupulous human review areas:

  • The end-to-end injection point in the add-capabilities sequence (must be per-DON, and must not accidentally mutate shared CapabilityConfigs across DON iterations).
  • Correctness of the Job Distributor → on-chain config mapping (ensuring no missing nodes lead to partial configs).

Suggested reviewers (per .github/CODEOWNERS for /deployment/cre):

  • @smartcontractkit/keystone
  • @smartcontractkit/operations-platform

@trunk-io
Copy link

trunk-io bot commented Mar 24, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link

@yashnevatia yashnevatia marked this pull request as draft March 24, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants