Reduce vault E2E test sleep times by ~80s#21662
Closed
prashantkumar1982 wants to merge 5 commits intodevelopfrom
Closed
Reduce vault E2E test sleep times by ~80s#21662prashantkumar1982 wants to merge 5 commits intodevelopfrom
prashantkumar1982 wants to merge 5 commits intodevelopfrom
Conversation
…etrieval tests Remove the `vault.secrets.get` method from the gateway surface entirely: - Remove `GetSupportedMethods()` dev-build conditional that exposed the method - Remove `handleSecretsGet()` and `getEncryptionKeys()` from the gateway handler - Remove the `MethodSecretsGet` case from the gateway-side handler and aggregator - Remove the now-unused `capRegistry` field from `GatewayHandler` Replace the commented-out gateway-based get test with a WASM workflow that calls `runtime.GetSecret()`, and add cross-namespace E2E coverage proving that secrets with the same ID in different namespaces are fully independent (create, get, update, list, delete all scoped to their namespace). Made-with: Cursor
- In the vaultsecret WASM workflow, check that the GetSecret error specifically contains "key does not exist" instead of accepting any error as proof the secret was deleted. This prevents config-propagation, transport, or decryption failures from masking real bugs. - In updateVaultCapabilityConfigInRegistry, replace the fire-and-sleep pattern with sethClient.WaitMined + receipt status assertion so a reverted or stuck tx fails the test immediately instead of causing a downstream workflow flake. Made-with: Cursor
- Fix goimports import ordering in v2_vault_don_test.go - Add vaultsecret module to go.md dependency graph - Fix updateVaultCapabilityConfigInRegistry to dynamically find the DON that has vault@1.0.0 instead of hardcoding "workflow-don", which fails in the workflow-gateway-capabilities topology where vault lives on "capabilities-don" Made-with: Cursor
…n in multi-DON topology In the workflow-gateway-capabilities topology, the vault capability runs on a separate capabilities-don. Without MethodConfigs, the launcher treats vault as a V1 capability and passes nil transmissionConfig. Since secrets.go doesn't set Config on the CapabilityRequest, the V1 fallback path fails with "cannot unwrap nil values.Map" when extracting transmission config. Adding RemoteExecutableConfig for the vault.secrets.get method ensures the V2 Don2Don framework is used, which sets transmissionConfig from the on-chain registry config rather than requiring it per-request.
- Remove redundant 30s "Vault DON ready" sleep (OCR3 already warm after registry syncer wait) - Reduce registry syncer propagation wait from 30s to 15s (syncer polls every 12s; one tick + margin) - Reduce allowlist propagation sleep from 10s to 6s per call (syncer polls every 5s; 9 calls × 4s saved = 36s) Validated locally: all vault E2E tests pass in ~275s (down from ~355s).
product-security-plaid-production
bot
requested review from
pavel-raykov and
silaslenihan
Contributor
|
👋 prashantkumar1982, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
pavel-raykov
approved these changes
Mar 24, 2026
Contributor
Author
|
This was superceded with #21660 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registrySyncerpolls every 12s (defaultTickInterval), so one tick + margin is sufficient.WorkflowRegistrySyncerpolls allowlisted requests every 5s (defaultTickIntervalForAllowlistedRequests), so one tick + margin is sufficient. With 9 calls in the test, this saves ~36s alone.Measured speedup