Trigger Capability Event ACKs #20628
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanTinianov
changed the title
… into PLEX-1460-delivery-acks
Contributor
|
I see you updated files related to
|
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
DylanTinianov
changed the title
… into PLEX-1460-delivery-acks
product-security-plaid-production
bot
requested review from
ChrisAmora and
JoshC2k
… into PLEX-1460-delivery-acks
|
| } | ||
| // TODO: We need TriggerCapID here, not the registration triggerID in order to match? | ||
| // TODO: Or we call AckEvent on all triggers and they must noop if triggerID doesn't match? | ||
| if info.ID == triggerID { // ' |
Contributor
There was a problem hiding this comment.
I believe this should be fixed by parameterizing the trigger method name, as it happens with register/unregister, and do the lookup using that, not the triggerID
| startTime := e.cfg.Clock.Now() | ||
| executionLogger.Infow("Workflow execution starting ...") | ||
| _ = events.EmitExecutionStartedEvent(ctx, loggerLabels, triggerEvent.ID, executionID) | ||
| registrationID := fmt.Sprintf("trigger_reg_%s_%d", e.cfg.WorkflowID, wrappedTriggerEvent.triggerIndex) |
Contributor
There was a problem hiding this comment.
could you extract this trigger_reg_%s_%d as a constant, and re use it in the engine.go#runTriggerSubscriptionPhase() and in the existing test TestEngine_Execution()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Trigger Event ACKs via the Workflow Engine and Don2Don communication.
EPIC Guaranteed Trigger Delivery
Requires
Extend Capabilities (chainlink-common)
Integrate BaseTriggerCapability with LogTriggerService (capabilities)