PLEX-2935/generalize monitoring#2132
Merged
ilija42 merged 7 commits intoJun 18, 2026
Merged
Conversation
|
jmank88
reviewed
Jun 8, 2026
dhaidashenko
reviewed
Jun 8, 2026
dhaidashenko
approved these changes
Jun 18, 2026
ilija42
reviewed
Jun 18, 2026
| c.actionMetrics.OnError(ctx, "GetAccountInfoWithOpts", tsStart, time.Now(), isUserError, capmon.ActionMetricAttributes("GetAccountInfoWithOpts", metadata, mc.MetricsAttributes, metricAttrs)...) | ||
| return nil, capabilities.ResponseMetadata{}, nil, err | ||
| } | ||
| mc.Logger.Infow("capability succeeded", logKvs...) |
Contributor
There was a problem hiding this comment.
Are you removing these logs from solana cap actions in a followup?
ilija42
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
MonitoringContext() implementation by solana capability here
Summary
Adds
--with-monitoringto v2 capability server generation. Action lifecycle monitoring (initiated / success / error) lives in the generated server wrapper, not in action implementations.What changed
--with-monitoring— generated server wraps RPC dispatch with lifecycle logs + metricspkg/capabilities/v2/monitoring/— shared monitoring package:MonitoringContext()onClientCapability(logger + chain/capability labels)MonitoringLabelson request types (LogKVs()/MetricKVs())capabilities_v2_action_count,capabilities_v2_action_duration(method,outcomelabels)Why
go generate --with-monitoringNotes
ProtoProcessorDashboard query comparison (EVM vs Solana v2)
EVM — one metric name per action × outcome, stitched with
label_replaceEach RPC/outcome pair is a separate metric. Dashboards must list every series and derive an
actionlabel from__name__:Adding a new RPC requires new metric names and a new
label_replacebranch in every panel.Solana (v2 unified) — same panel shape, one metric + labels
Equivalent error-rate panel:
methodreplaces derivedaction;outcome="error"replaces_error_countsuffixes:New RPCs appear automatically as new
methodlabel values — no dashboard query changes.Success rate by method (same unified model):