Skip to content

fix(httpapi): flaky activation scope assertion #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dumbris merged 2 commits into from
Sep 21, 2026
Merged

fix(httpapi): flaky activation scope assertion #1329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaa300c
Fix flaky activation scope assertion
lux-liang Sep 20, 2026
5e8f032
test(httpapi): simplify leak-check assertion to match file idiom
Dumbris Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions internal/httpapi/scope_round11_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package httpapi

import (
"bytes"
"fmt"
"net/http"
"net/http/httptest"
"path/filepath"
Expand Down Expand Up @@ -33,9 +34,8 @@ import (
const (
activationClientAlpha = "cursor-on-operators-laptop"
activationClientBeta = "claude-desktop-on-operators-laptop"
// A count no other field of a /status response can produce: the sibling
// numbers are unix timestamps and single-digit server counts, so a raw-body
// "4711" assertion cannot pass for an unrelated reason.
// A distinctive count whose complete JSON number token is checked below.
// The bare digits may also occur inside an unrelated unix timestamp.
activationCalls24h = 4711
activationSavedBucket = "10k_100k"
)
Expand Down Expand Up @@ -119,7 +119,10 @@ func TestGetStatus_ActivationBlockIsOperatorOnly(t *testing.T) {
body := agent.Body.String()
assert.NotContains(t, body, activationClientAlpha, "MCP-client inventory leaked to a scoped caller")
assert.NotContains(t, body, activationClientBeta, "MCP-client inventory leaked to a scoped caller")
assert.NotContains(t, body, "4711", "exact deployment-wide retrieve_tools count leaked to a scoped caller")
assert.NotContains(t, body, fmt.Sprintf(`":%d,`, activationCalls24h),
"exact deployment-wide retrieve_tools count leaked to a scoped caller")
assert.NotContains(t, body, fmt.Sprintf(`":%d}`, activationCalls24h),
"exact deployment-wide retrieve_tools count leaked to a scoped caller")
assert.NotContains(t, body, activationSavedBucket, "deployment-wide tokens-saved bucket leaked to a scoped caller")
// Key names too, so a projection that kept the numbers under a renamed or
// re-nested key would still fail.
Expand Down
Loading