Skip to content

fix(telemetry): opt-out beacon tolerates a Service without an HTTP client (shuffle-lane crash) #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dumbris merged 1 commit into from
Sep 18, 2026
+6 −0
Merged

fix(telemetry): opt-out beacon tolerates a Service without an HTTP client (shuffle-lane crash) #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/telemetry/optout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,12 @@ func (s *Service) SendOptOutBeacon(ctx context.Context) error {
}
req.Header.Set("Content-Type", "application/json")

// The beacon is fire-and-forget from NotifyConfigChanged, so a Service
// built without a client (test literals do this) must not take the
// goroutine — and the test binary — down with a nil dereference.
if s.client == nil {
return errors.New("send opt-out beacon: no HTTP client configured")
}
resp, err := s.client.Do(req)
if err != nil {
return fmt.Errorf("send opt-out beacon: %w", err)
Expand Down
Loading