Conversation
|
Thanks for this!! Could you take a look at some of the tests that have failed? |
charts/pixelfed/values.yaml
Outdated
| # -- Enable S3/Object Storage | ||
| enable_cloud: false | ||
| # -- Posts are published without waiting for media to be optimized/uploaded to S3. However, posts may be federated without S3 urls. | ||
| media_fast_process: true #TODO test this as false |
There was a problem hiding this comment.
no in-line comments, please
There was a problem hiding this comment.
didnt mean to leave my todos 😄
charts/pixelfed/values.yaml
Outdated
| # -- accessMode | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| - ReadWriteOnce # TODO must be ReadWriteMany for seperate worker to work |
There was a problem hiding this comment.
no inline comments, please
There was a problem hiding this comment.
This comment should go into the line 387 comment for the access for further helping of others with horizon
947a7c2 to
95b79ff
Compare
40dd29f to
ec1c55e
Compare
comments addressed, and passing lint+test now, also added in a test case for enabling the minio subchart! Not sure I'll be able to pass "Generate helm docs", its failing to push changes to my repo/branch: Not sure if its possible to solve based on this issue thread: actions/checkout#455. I did try enabling actions on my fork, as well as making the permissions to "Allow all actions and reusable workflows". Any ideas? We could run it on merge to main of this repo, but that doesn't give a chance for you/others to review beforehand |
Adding a minio subchart will help with the complexity of object storage during deployments. Would more than welcome feedback since this probably the most complex helm logic I've worked on.
Enabling the subchart with the other default values results in the following:
We do not:
.Values.pixelfed.pf.enable_cloud). I can provide example values for using S3 if we want to add it to the readme..Values.pixelfed.s3.url). In my testing it appears this can be updated after the factCloses #55