Skip to content

attribute error handling #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phys-cgarnier wants to merge 2 commits into
base: main
Choose a base branch
from
Open

attribute error handling #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1a2955
added error handling to catch the exception raised get searching for …
phys-cgarnier Nov 14, 2025
735ca9b
Merge branch 'main' into attrib-error-patch
phys-cgarnier Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions simulation_server/beamdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def __init__(
self.virtual_accelerator = virtual_accelerator

self.server = server

self.omitted = []

# get list of pvs that should be updated every time we write to a PV
self.measurement_pvs = self.get_measurement_pvs()
Expand Down Expand Up @@ -307,7 +307,14 @@ def update_pvs(self, pv_list):
print("PVs updated.")

def read(self, reason):
value = self.virtual_accelerator.get_pvs([reason])[reason]
try:
value = self.virtual_accelerator.get_pvs([reason])[reason]
except AttributeError as e:
if reason not in self.omitted:
self.omitted.append(reason)
print(f"Error getting param for {reason}: {e}, do not use {reason}")
return 0
Comment on lines +310 to +316
Copy link
Member

@JJL772 JJL772 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would error out when caget-ing SOMETHING.DRVL. It might be worthwhile to ignore PVs with a .XYZ suffix.


self.server.set_pv(reason, value)
try:
self.setParam(reason, value)
Expand Down