-
Notifications
You must be signed in to change notification settings - Fork 6
Simulation Threading #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JJL772
wants to merge
26
commits into
main
Choose a base branch
from
pr-simulation-threading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33e6cde to
be3827c
Compare
This helps improve performance and allows for writes to be batched.
d249782 to
cab3d0a
Compare
Sourcing the stuff in /sdf/ starts to become a nuisance when you have /sdf mounted via sshfs
…mulation-Server into pr-simulation-threading
…Linac-Simulation-Server into pr-simulation-threading
…nd grabs specific fields
…th images in the server, test also needed axes swapped to be consistent
| size_x = output["OTRS:IN20:571:Image:ArraySize0_RBV"] | ||
| size_y = output["OTRS:IN20:571:Image:ArraySize1_RBV"] | ||
| image = np.array(image).reshape((size_y, size_x)) | ||
| image = np.array(image).reshape((size_x, size_y)) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please compare this to the calculations done in lcls-tools screen.image to make sure it is consistent. I believe it is reversed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to work around timeout issues seen when running Badger against Linac-Simulation-Server.
My understanding of the issue is:
caputreporting a timeout when it tries to provide a readback of the new valueThere are two ways to fix this:
I opted for option 2 just to avoid breaking PVA.
VIRT:BEAM:SIMULATE_TIMEOUTdefines the window in which PVs can be batched before the simulation is re-runVIRT:BEAM:SIMULATEwill force the simulation to occur regardless ofVIRT:BEAM:SIMULATE_TIMEOUTsetting. This is mostly handy for working with the server from the command line.With the timeout method, no changes are required to Badger-Resources