Skip to content

ci: version the private package under changesets v3 config defaults - #672

Merged
zimeg merged 1 commit into
mainfrom
fix/version-private-packages
Aug 12, 2026
Merged

ci: version the private package under changesets v3 config defaults#672
zimeg merged 1 commit into
mainfrom
fix/version-private-packages

Conversation

@zimeg

@zimeg zimeg commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

This pull request restores versioning of the private root package after the @changesets/cli v2 → v3 upgrade in #670, which is why the release PR (#668) closed and pending changesets are stranded (see #668, and the discussion on #670).

  • build(deps): bump js-yaml and @changesets/cli #670 bumped @changesets/cli (2.31.0 → 3.0.0) and pulled in @changesets/config v4, which flips the default for versioning private packages.
  • In v2, private packages were versioned automatically (no git tag). Per the changesets v3 migration guide, v3 disables both by default: "Changesets v3 now disables both behaviors by default as most projects don't version private packages."
  • This repo's root package is private: true, so changeset version now finds nothing to bump and produces an empty diff. changesets/action then force-pushes main's tip onto changeset-release/main, closing the release PR with No commits between main and changeset-release/main.
  • Fix: opt in explicitly with "privatePackages": { "version": true, "tag": false }. version: true restores the bump; tag: false keeps this repo's hand-rolled vX/vX.Y tagging in release.yml untouched (changesets never tagged here — this action is not published to npm).
  • Also bumps the config $schema URL to @changesets/config@4.0.0 to match the resolved dependency.

Verified locally against the CI-resolved @changesets/cli@3.0.0 / @changesets/config@4.0.0: before the change changeset status shows no packages to bump; after it shows @slack/slack-github-action -> 4.1.0, changeset version consumes the pending changeset and bumps package.json/CHANGELOG.md, leaving a non-empty diff.

Testing

  • After merge, watch the Release workflow run on main and confirm it recreates the chore: release PR (targeting 4.1.0) with a non-empty diff, rather than closing it.

Requirements

…ults

The @changesets/cli v2 -> v3 bump (#670) also upgraded @changesets/config
to v4, which flips the default for versioning private packages. In v2,
private packages were versioned automatically (without git tags); v3
disables both by default. This repo's root package is `private: true`, so
`changeset version` now treats it as un-versionable and produces an empty
diff. The release action then force-pushes main's tip onto
changeset-release/main, which closes the release PR with "No commits
between main and changeset-release/main" and strands pending changesets.

Restore the prior behavior by opting in explicitly, per the changesets v3
migration guide, and bump the config `$schema` to match the resolved v4.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@changeset-bot

changeset-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1322807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (638050b) to head (1322807).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines         732      732           
=======================================
  Hits          731      731           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg self-assigned this Aug 12, 2026
@zimeg zimeg added bug Something isn't working github_actions Pull requests that update GitHub Actions code release Tags for an updated version labels Aug 12, 2026
@zimeg zimeg changed the title fix: version the private package under changesets v3 config defaults ci: version the private package under changesets v3 config defaults Aug 12, 2026
@zimeg zimeg added this to the 4.1 milestone Aug 12, 2026
@zimeg
zimeg marked this pull request as ready for review August 12, 2026 17:19
@zimeg
zimeg requested a review from a team as a code owner August 12, 2026 17:19
@zimeg zimeg mentioned this pull request Aug 12, 2026
@zimeg

zimeg commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

🚀 Confidence built in #673 so let's now merge this.

@zimeg
zimeg merged commit faf8f8f into main Aug 12, 2026
15 checks passed
@zimeg
zimeg deleted the fix/version-private-packages branch August 12, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code release Tags for an updated version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant