feat: support features.code_channels in app manifest round trip - #670
Open
mcodik wants to merge 1 commit into
Open
feat: support features.code_channels in app manifest round trip#670mcodik wants to merge 1 commit into
mcodik wants to merge 1 commit into
Conversation
AppFeatures had no field for code_channels, so Go's json.Unmarshal silently dropped it before the manifest was sent to apps.manifest.validate/update. Add it as a RawJSON passthrough so any future sub-fields survive without further struct changes. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 78.19% 78.20% +0.01%
==========================================
Files 239 239
Lines 18149 18149
==========================================
+ Hits 14192 14194 +2
+ Misses 3957 3955 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zimeg
changed the title
zimeg
approved these changes
Sep 9, 2026
| ManifestSlashCommandsItems []ManifestSlashCommandsItem `json:"slash_commands,omitempty" yaml:"slash_commands,flow,omitempty"` | ||
| Search *Search `json:"search,omitempty" yaml:"search,flow,omitempty"` | ||
| RichPreviews *RichPreviews `json:"rich_previews,omitempty" yaml:"rich_previews,flow,omitempty"` | ||
| CodeChannels *RawJSON `json:"code_channels,omitempty" yaml:"code_channels,flow,omitempty"` |
Member
There was a problem hiding this comment.
👁️🗨️ question: Should we extend values for code_channels to include the following or are these values sometimes changed?:
type CodeChannels struct {
Enabled *bool `json:"enabled,omitempty" yaml:"enabled,omitempty"`
SlashCommandURL string `json:"slash_command_url,omitempty" yaml:"slash_command_url,omitempty"`
}
Member
There was a problem hiding this comment.
Add it as a RawJSON passthrough so any future sub-fields survive without further struct changes.
🌚 note: Am open to this as well but think we benefit from strict structures overall after stable API releases!
zimeg
added
enhancement
Member
|
📚 note: I'm open to keeping this with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Lets devs set code_channels feature in their manifests, and have it display in
manifest exportSummary
AppFeatures had no field for code_channels, so Go's json.Unmarshal silently dropped it before the manifest was sent to apps.manifest.validate/update. Add it as a RawJSON passthrough so any future sub-fields survive without further struct changes.
Preview
Before
After
Testing
Run
manifest exporton app that has the code_channels feature set in the manifestNotes
(Add any additional context, trade-offs, or follow-up items)
Requirements