feat(create): fetch remote manifest after linking app during create#585
Open
srtaalej wants to merge 9 commits into
Open
feat(create): fetch remote manifest after linking app during create#585srtaalej wants to merge 9 commits into
srtaalej wants to merge 9 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
+ Coverage 71.64% 71.70% +0.06%
==========================================
Files 226 226
Lines 19148 19189 +41
==========================================
+ Hits 13718 13759 +41
+ Misses 4221 4219 -2
- Partials 1209 1211 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
slack create --appnow fetches the app's manifest from remote settings and writes it to the project'smanifest.json, replacing the template's generic manifest with the actual app configuration.Summary
Follow-up to #565. After linking an existing app during
slack create --app --template, the CLI now fetches the remote manifest from App Settings and overwrites the template'smanifest.jsonwith it.This also updates
LinkExistingAppto return (*types.SlackAuth, error) so callers can use the auth token for subsequent API calls (like manifest fetching).Design decisions:
.slack/config.json— the remote content is written locallymanifest.jsonis overwritten (notmanifest.ts/.jswhich are code files in Deno projects)Testing
Manual:
make build./bin/slack create my-test -t slack-samples/bolt-js-starter-template --app <real-app-id> --environment localmy-test/manifest.jsoncontains the remote app's manifestNotes 🔴
.slack/config.jsonafter writing the fetched manifest? Currently left as local so the user "owns" the file going forward.manifest.ts/.js(Deno SDK) projects are not supportedRequirements