Skip to content

feat: add debug logging and retry support to icon upload #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srtaalej wants to merge 5 commits into
base: main
Choose a base branch
from
+5 −16
Open

feat: add debug logging and retry support to icon upload #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
adb56b9
fix: add debug logging and retry support to icon upload
srtaalej Apr 20, 2026
560402d
Merge branch 'main' into ale-upload-icon
zimeg Apr 20, 2026
efeebc9
Update internal/api/icon.go
srtaalej Apr 20, 2026
c09d795
remove uploading icon
srtaalej Apr 20, 2026
59168bd
Merge branch 'main' into ale-upload-icon
srtaalej Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions internal/api/icon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,32 +135,24 @@ func (c *Client) uploadIcon(ctx context.Context, fs afero.Fs, token, appID, icon
var userAgent = fmt.Sprintf("slack-cli/%s (os: %s)", cliVersion, runtime.GOOS)
request.Header.Add("User-Agent", userAgent)

resp, err := c.httpClient.Do(request)
if err != nil {
return IconResult{}, err
}
defer resp.Body.Close()
c.io.PrintDebug(ctx, "HTTP Request: %v %v %v", request.Method, request.URL, request.Proto)
c.io.PrintDebug(ctx, "HTTP Request User-Agent: %s", request.Header.Get("User-Agent"))
c.io.PrintDebug(ctx, "HTTP Request Body: <binary image data, %d bytes>", body.Len())

span.SetTag("status_code", resp.StatusCode)

respBody, err := io.ReadAll(resp.Body)
respBytes, err := c.DoWithRetry(ctx, request, span, false, sURL)
if err != nil {
return IconResult{}, err
}

var result iconResponse
err = json.Unmarshal(respBody, &result)
err = json.Unmarshal(respBytes, &result)
if err != nil {
return IconResult{}, err
}

span.SetTag("ok", result.Ok)

if !result.Ok {
span.SetTag("error", result.Error)
return IconResult{}, fmt.Errorf("%s error: %s", sURL.String(), result.Error)
}

// return result
return IconResult{}, nil
}
3 changes: 0 additions & 3 deletions internal/pkg/apps/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,6 @@ func InstallLocalApp(ctx context.Context, clients *shared.ClientFactory, orgGran
}
}
if iconPath != "" {
clients.IO.PrintDebug(ctx, "uploading icon")
_, iconErr := clients.API().IconSet(ctx, clients.Fs, token, app.AppID, iconPath)
if iconErr != nil {
clients.IO.PrintDebug(ctx, "icon error: %s", iconErr)
Expand Down Expand Up @@ -656,8 +655,6 @@ func updateIcon(ctx context.Context, clients *shared.ClientFactory, iconPath, ap
span, ctx = opentracing.StartSpanFromContext(ctx, "updateIcon")
defer span.Finish()

clients.IO.PrintDebug(ctx, "uploading icon")

var err error
if clients.Config.WithExperimentOn(experiment.SetIcon) {
_, err = clients.API().IconSet(ctx, clients.Fs, token, appID, iconPath)
Expand Down
Loading