-
Notifications
You must be signed in to change notification settings - Fork 24
refactor: use the fake test client in more api tests #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 64.58% 64.59% +0.01%
==========================================
Files 212 212
Lines 17505 17505
==========================================
+ Hits 11305 11308 +3
+ Misses 5134 5133 -1
+ Partials 1066 1064 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👻 Spooked but initial tests ran not as fast: 1 minute 8 seconds Edit: I don't think this should motivate the change - was curious! |
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦸🏻 Heroic test refactor @zimeg! Thanks for bringing in our table test standard format as well!
🧠 In the future, we may want to rename FakeClient to MockClient (or ClientMock).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: 👌🏻
|
@mwbrooks Thanks so much for a kind review too! I'm optimistic that these changes will make ongoing contribution a bit more clear in pattern so let's merge this now.
Oh I thought about this too but found it unclear if a "fake" client was meant to be different than a "mock" client... So open to this follow up if it makes more sense to you! 💡 |
Summary
This PR refactors tests to use the
NewFakeClientmore often for less duplication and perhaps faster test runs?Notes
main: 46 seconds ⏳Requirements