Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Oct 31, 2025

Summary

This PR fixes a formatting issue on main to avoid build errors after updates to golangci-lint tooling:

golangci-lint run
internal/config/experiments_test.go:303:26: printf: missing ... in args forwarded to printf-like function (govet)
                mockOutput.WriteString(fmt.Sprintf(format, a))
                                       ^
1 issues:
* govet: 1
make: *** [Makefile:55: lint] Error 1

Requirements

@zimeg zimeg added this to the Next Release milestone Oct 31, 2025
@zimeg zimeg self-assigned this Oct 31, 2025
@zimeg zimeg requested a review from a team as a code owner October 31, 2025 01:01
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.61%. Comparing base (f30df06) to head (f8f388f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   63.07%   64.61%   +1.53%     
==========================================
  Files         212      212              
  Lines       21857    17505    -4352     
==========================================
- Hits        13786    11310    -2476     
+ Misses       7008     5130    -1878     
- Partials     1063     1065       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg
Copy link
Member Author

zimeg commented Oct 31, 2025

🧪 note: Merging this to unblock tests on main for upcoming releases!

@zimeg zimeg merged commit b861e2d into main Oct 31, 2025
8 checks passed
@zimeg zimeg deleted the zimeg-style-fprintf-writestring branch October 31, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants