Skip to content

Conversation

@srtaalej
Copy link
Contributor

@srtaalej srtaalej commented Oct 21, 2025

Changelog

When reinstalling the Slack CLI after some time, we now avoid blocking the installation script with an automatic prompt to update to the latest version.

Summary

When the _fingerprint command is ran, the cli posts an unwanted upgrade notification:
Screenshot 2025-10-20 at 7 44 03 PM
This PR gets rid of that notification for lack _fingerprint and tests that it still shows up for other commands.

Requirements

@srtaalej srtaalej requested a review from a team as a code owner October 21, 2025 00:53
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.03%. Comparing base (4db880d) to head (c1ec747).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   63.00%   63.03%   +0.02%     
==========================================
  Files         212      212              
  Lines       21857    21857              
==========================================
+ Hits        13772    13778       +6     
+ Misses       7020     7014       -6     
  Partials     1065     1065              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej srtaalej self-assigned this Oct 21, 2025
@srtaalej srtaalej added the enhancement M-T: A feature request for new functionality label Oct 21, 2025
@zimeg zimeg changed the title fix: remove update notifs from the fingerprint cmd fix: remove update notification from the "_fingerprint" command Oct 21, 2025
@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment and removed enhancement M-T: A feature request for new functionality labels Oct 21, 2025
@zimeg zimeg added this to the Next Release milestone Oct 21, 2025
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srtaalej LGTM! This is a nice fix for unexpected happenings when using this command 👾

It's so great to find these test cases too. I'm confused about the coverage report but the test cases help kind with changes upcoming overall 🙏

@zimeg zimeg added the changelog Use on updates to be included in the release notes label Oct 21, 2025
@zimeg zimeg changed the title fix: remove update notification from the "_fingerprint" command fix: avoid blocking the installation script when comparing the current install Oct 21, 2025
@zimeg zimeg changed the title fix: avoid blocking the installation script when comparing the current install fix: avoid blocking the installation script with an automatic update prompt Oct 21, 2025
@zimeg
Copy link
Member

zimeg commented Oct 21, 2025

@srtaalej I made a quick addition to this PR to add a line for our release notes with a message for those following along 📚

Changelog

When reinstalling the Slack CLI after some time, we now avoid blocking the installation script with an automatic prompt to update to the latest version.

Please adjust this to whatever makes sense! For enhancements or bug labels - perhaps others - this is something we've started adding alongside PRs to make updates read well 🤖

At risk of rambling, I am wondering if a CHANGELOG.md file might be something we can use for release automations...

@zimeg zimeg merged commit 0e48387 into main Oct 21, 2025
8 checks passed
@zimeg zimeg deleted the ale-update-ignored-cmds branch October 21, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants