-
Notifications
You must be signed in to change notification settings - Fork 24
fix: avoid blocking the installation script with an automatic update prompt #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 63.00% 63.03% +0.02%
==========================================
Files 212 212
Lines 21857 21857
==========================================
+ Hits 13772 13778 +6
+ Misses 7020 7014 -6
Partials 1065 1065 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srtaalej LGTM! This is a nice fix for unexpected happenings when using this command 👾
It's so great to find these test cases too. I'm confused about the coverage report but the test cases help kind with changes upcoming overall 🙏
|
@srtaalej I made a quick addition to this PR to add a line for our release notes with a message for those following along 📚
Please adjust this to whatever makes sense! For At risk of rambling, I am wondering if a |
Changelog
When reinstalling the Slack CLI after some time, we now avoid blocking the installation script with an automatic prompt to update to the latest version.
Summary
When the

_fingerprintcommand is ran, the cli posts an unwanted upgrade notification:This PR gets rid of that notification for
lack _fingerprintand tests that it still shows up for other commands.Requirements