Skip to content

fix(webhook) #2614: added export for 'addAppMetadata'#2626

Merged
srtaalej merged 5 commits into
slackapi:mainfrom
pushkarbanjare:fix/#2614
Jun 16, 2026
Merged

fix(webhook) #2614: added export for 'addAppMetadata'#2626
srtaalej merged 5 commits into
slackapi:mainfrom
pushkarbanjare:fix/#2614

Conversation

@pushkarbanjare

@pushkarbanjare pushkarbanjare commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #2614

'addAppMetadata' already exists in '@slack/webhook', but it isn't exported from the package entry point, so 'import { addAppMetadata } from "@slack/webhook"' doesn't resolve. This adds the missing re-export, bringing it in line with
'@slack/web-api'.

Requirements

@pushkarbanjare pushkarbanjare requested a review from a team as a code owner June 14, 2026 19:02
@changeset-bot

changeset-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ae5637a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@srtaalej

Copy link
Copy Markdown
Contributor

hi @pushkarbanjare thank you for raising this issue and addressing it! I see that addAppMetadata is exposed in web-api but not in webhook. im looping in another team member to make sure addAppMetadata wasn't kept internal intentionally 🤔 will keep this thread updated with what i find !✨

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (59a6329) to head (ae5637a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.01%     
==========================================
  Files          62       63       +1     
  Lines       10238    10256      +18     
  Branches      451      452       +1     
==========================================
+ Hits         9100     9118      +18     
  Misses       1117     1117              
  Partials       21       21              
Flag Coverage Δ
cli-hooks 88.90% <100.00%> (+0.01%) ⬆️
cli-test 88.90% <100.00%> (+0.01%) ⬆️
logger 88.90% <100.00%> (+0.01%) ⬆️
oauth 88.90% <100.00%> (+0.01%) ⬆️
socket-mode 88.90% <100.00%> (+0.01%) ⬆️
web-api 88.90% <100.00%> (+0.01%) ⬆️
webhook 88.90% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@srtaalej srtaalej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐

@srtaalej srtaalej merged commit 59124ef into slackapi:main Jun 16, 2026
12 checks passed
@zimeg zimeg added semver:minor enhancement M-T: A feature request for new functionality pkg:webhook applies to `@slack/webhook` labels Jun 16, 2026
@zimeg zimeg added this to the webhook@next milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed enhancement M-T: A feature request for new functionality pkg:webhook applies to `@slack/webhook` semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(webhook): export addAppMetadata from @slack/webhook

3 participants