ci: simplify test scripts and separate coverage from test runs by WilliamBergamin · Pull Request #2566 · slackapi/node-slack-sdk

WilliamBergamin · 2026-04-29T19:57:55Z

Summary

Separated test coverage from regular test runs each package now has a test script and a test:coverage script. Previously most packages aliased test to test:unit which always included coverage instrumentation.
Removed the test:node18 scripts these were workarounds for Node 18 lacking --test-reporter support.
Simplified CI workflow replaced the split Run tests (Node 18/20) / Run tests (Node 22+) steps with a single Run tests step for most matrix entries, plus a Run test coverage step only on the latest supported Node version.
Added glob-bin as a root devDependency to replace bash -O globstar glob expansion in test scripts (cross-platform compatibility on Windows CI).

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

changeset-bot · 2026-04-29T19:58:03Z

🦋 Changeset detected

Latest commit: af3165f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2026-04-29T19:59:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.41%. Comparing base (62c5a3f) to head (af3165f).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files          62       62           
  Lines       10251    10251           
  Branches      415      415           
=======================================
  Hits         8961     8961           
  Misses       1269     1269           
  Partials       21       21

Flag	Coverage Δ
cli-hooks	`87.41% <ø> (ø)`
cli-test	`87.41% <ø> (ø)`
logger	`87.41% <ø> (ø)`
oauth	`87.41% <ø> (ø)`
socket-mode	`87.41% <ø> (ø)`
web-api	`87.41% <ø> (ø)`
webhook	`87.41% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zimeg

@WilliamBergamin Amazing improvements to CI health! I like the pattern of checking coverage for the latest version so much 🧪 ✨

I'm approving with a few notes and question about dependencies noted? If this all seems expected please do merge:

Added glob-bin as a root devDependency to replace bash -O globstar glob expansion in test scripts (cross-platform compatibility on Windows CI).

I added af3165f during review that hinted toward this package, but was this still used?

🚢 💨

zimeg · 2026-04-29T22:22:35Z

🔭 note: I'm so curious for what happens to this file in upcoming releases!

zimeg · 2026-04-29T22:22:57Z

  pull_request:

+env:
+  LATEST_SUPPORTED_NODE: "24.x"


🧠 praise: Super nice to surface this clear!

zimeg · 2026-04-29T22:27:42Z

@@ -64,15 +67,14 @@ jobs:
        run: npm run lint
      - name: Build docs


Suggested change

- name: Build docs

- name: Build docs

if: matrix.node-version == env.LATEST_SUPPORTED_NODE

⌛ thought: We can save ~20 seconds for most runs with this? But perhaps it's adjacent to this PR!

zimeg · 2026-04-29T22:27:59Z

-    "test": "npm run test:unit",
-    "test:node18": "bash -c 'node --test --test-reporter=spec src/*.test.js'",
-    "test:unit": "node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --test src/*.test.js"
+    "test": "bash -c 'node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --test src/*.test.js'",


Suggested change

"test": "bash -c 'node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --test src/*.test.js'",

"test": "bash -c 'node --test src/*.test.js'",

🧪 thought(non-blocking): I like the pattern of a minimal test script and a more complex test:coverage but am uncertain which flags remain needed for the first?

zimeg · 2026-04-29T22:31:05Z

 npm test --workspace=packages/web-api         # all tests
-npm run test:unit --workspace=packages/web-api # unit only
+npm test --workspace=packages/web-api            # unit only


🔭 thought: One of these might be good to remove since it's unclear which test suite is used at a glance?

zimeg · 2026-04-29T22:31:37Z

    "lint": "npx @biomejs/biome check packages",
    "lint:fix": "npx @biomejs/biome check --write packages",
    "test": "npm test --workspaces --if-present",
+    "test:coverage": "npm run test:coverage --workspaces --if-present",


🏆 praise: These patterns are joined well here!

ci: simplify test scripts and separate coverage from test runs

768f391

WilliamBergamin self-assigned this Apr 29, 2026

WilliamBergamin requested a review from a team as a code owner April 29, 2026 19:57

WilliamBergamin added semver:patch enhancement M-T: A feature request for new functionality github_actions Pull requests that update GitHub Actions code labels Apr 29, 2026

WilliamBergamin added 6 commits April 29, 2026 16:33

Create simple-tests-shine.md

7c42d88

why did you want to use glob from the begining

01c5512

test out a fix

8ad082c

clean things up

f2ed2a0

make things work on windows

ef719c3

make it pass

279cda0

WilliamBergamin requested a review from zimeg April 29, 2026 21:51

style: remove blank line from package json file

af3165f

zimeg approved these changes Apr 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: simplify test scripts and separate coverage from test runs#2566

ci: simplify test scripts and separate coverage from test runs#2566
WilliamBergamin wants to merge 8 commits intomainfrom
simplify-ci-testing

WilliamBergamin commented Apr 29, 2026

Uh oh!

changeset-bot Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

zimeg left a comment

Uh oh!

zimeg Apr 29, 2026

Uh oh!

zimeg Apr 29, 2026

Uh oh!

zimeg Apr 29, 2026

Uh oh!

zimeg Apr 29, 2026

Uh oh!

zimeg Apr 29, 2026

Uh oh!

zimeg Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -64,15 +67,14 @@ jobs:
		run: npm run lint
		- name: Build docs

	- name: Build docs
	- name: Build docs
	if: matrix.node-version == env.LATEST_SUPPORTED_NODE

	"test": "bash -c 'node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --test src/*.test.js'",
	"test": "bash -c 'node --test src/*.test.js'",

Conversation

WilliamBergamin commented Apr 29, 2026

Summary

Requirements

Uh oh!

changeset-bot Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Apr 29, 2026 •

edited

Loading

codecov Bot commented Apr 29, 2026 •

edited

Loading