fix(socket-mode): await client disconnect on shutdown - #3042
Open
Grmiade wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 765ac9e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Grmiade
marked this pull request as ready for review
August 13, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SocketModeReceiver.stop()callsSocketModeClient.disconnect()but resolves immediately instead of awaiting it. Applications can therefore log that shutdown completed while the Socket Mode WebSocket close handshake is still in progress.Solution
Await the Socket Mode client's disconnect promise before resolving
SocketModeReceiver.stop(). This makesawait app.stop()reflect the actual receiver lifecycle and adds a regression test for the pending disconnect case.Validation
npx @biomejs/biome check src/receivers/SocketModeReceiver.ts test/unit/receivers/SocketModeReceiver.spec.tssrc/Assistant.tsandsrc/helpers.tson the clonedmainbranch.