Skip to content

ci: skip publish step if no release is needed#2894

Merged
zimeg merged 3 commits intomainfrom
zimeg-ci-release-check
Apr 27, 2026
Merged

ci: skip publish step if no release is needed#2894
zimeg merged 3 commits intomainfrom
zimeg-ci-release-check

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Apr 24, 2026

Summary

This PR skips the publish step if no release is needed 🚀

Fixes an issue where publishing is attempted after a recent release but no changsets exist. The "changelog" PR wasn't created so publishing was attempted! This didn't cause problems but requires unneeded approval.

Requirements

@zimeg zimeg added this to the @slack/bolt@next milestone Apr 24, 2026
@zimeg zimeg self-assigned this Apr 24, 2026
@zimeg zimeg requested a review from a team as a code owner April 24, 2026 22:13
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Apr 24, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 24, 2026

⚠️ No Changeset found

Latest commit: c9b1539

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zimeg zimeg requested a review from mwbrooks April 24, 2026 22:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.59%. Comparing base (a24cf85) to head (c9b1539).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2894   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          44       44           
  Lines        7855     7855           
  Branches      687      687           
=======================================
  Hits         7352     7352           
  Misses        498      498           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 24, 2026

📸 Example of these pending actions:

example

Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 💯

Left a non blocking comment

Comment thread .github/workflows/release.yml Outdated
name: Publish
needs: changelog
if: needs.changelog.outputs.hasChangesets == 'false'
if: needs.changelog.outputs.hasChangesets == 'false' && needs.changelog.outputs.releaseExists != 'true'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we don't want to check for == 'false' instead?

Suggested change
if: needs.changelog.outputs.hasChangesets == 'false' && needs.changelog.outputs.releaseExists != 'true'
if: needs.changelog.outputs.hasChangesets == 'false' && needs.changelog.outputs.releaseExists != 'false'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin Earlier iterations might've left odd patterns here! We landed a92b061 to continue if no release exists now with a false check 🏁

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 27, 2026

@WilliamBergamin I appreciate the review toward more sensible logic 🧠 ✨

Let's merge this now and mirror this in adjacent projects to avoid required approvals for attempted releases before changes land 🚀

@zimeg zimeg merged commit a5135ba into main Apr 27, 2026
26 checks passed
@zimeg zimeg deleted the zimeg-ci-release-check branch April 27, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants