-
Notifications
You must be signed in to change notification settings - Fork 0
fix: replace hardcoded Casey name in App Home with dynamic bot name #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mwbrooks
wants to merge
3
commits into
main
Choose a base branch
from
mwbrooks-hardcoded-casey-mention
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,9 @@ | |
|
|
||
|
|
||
| def build_app_home_view( | ||
| install_url: str | None = None, is_connected: bool = False | ||
| install_url: str | None = None, | ||
| is_connected: bool = False, | ||
| bot_user_id: str | None = None, | ||
| ) -> dict: | ||
| """Build the App Home Block Kit view with category buttons. | ||
|
|
||
|
|
@@ -37,13 +39,15 @@ def build_app_home_view( | |
| connected and will see a link to install. | ||
| is_connected: When ``True``, the user is connected and the MCP | ||
| status section shows as connected. | ||
| bot_user_id: The bot's user ID for dynamic mentions. | ||
| """ | ||
| mention = f" with <@{bot_user_id}>" if bot_user_id else "" | ||
| blocks = [ | ||
| { | ||
| "type": "header", | ||
| "text": { | ||
| "type": "plain_text", | ||
| "text": "Hey there :wave: I'm Casey, your IT helpdesk agent.", | ||
| "text": "Hey there :wave: I'm your IT helpdesk agent.", | ||
| }, | ||
| }, | ||
| { | ||
|
|
@@ -79,7 +83,7 @@ def build_app_home_view( | |
| "elements": [ | ||
| { | ||
| "type": "mrkdwn", | ||
| "text": "You can also mention me in any channel with `@Casey` or send me a DM.", | ||
| "text": f"You can also mention me in any channel{mention} or send me a DM.", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: Again, this reads funny but it does allow for a safe fallback when no bot id provided. |
||
| } | ||
| ], | ||
| }, | ||
|
|
@@ -102,7 +106,7 @@ def build_app_home_view( | |
| "elements": [ | ||
| { | ||
| "type": "mrkdwn", | ||
| "text": "Casey has access to search messages, read channels, and more.", | ||
| "text": "This agent has access to search messages, read channels, and more.", | ||
| } | ||
| ], | ||
| } | ||
|
|
@@ -123,7 +127,7 @@ def build_app_home_view( | |
| "elements": [ | ||
| { | ||
| "type": "mrkdwn", | ||
| "text": "The Slack MCP Server enables Casey to search messages, read channels, and more.", | ||
| "text": "The Slack MCP Server enables this agent to search messages, read channels, and more.", | ||
| } | ||
| ], | ||
| } | ||
|
|
@@ -144,7 +148,7 @@ def build_app_home_view( | |
| "elements": [ | ||
| { | ||
| "type": "mrkdwn", | ||
| "text": "The Slack MCP Server enables Casey to search messages, read channels, and more.", | ||
| "text": "The Slack MCP Server enables this agent to search messages, read channels, and more.", | ||
| } | ||
| ], | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: "Helpdesk" is renamed in PR #65