fix(toolchain): correct stale rust-toolchain.toml comment drift#316
Merged
Conversation
The comment block claimed the pin must stay at nightly-2026-04-17 to avoid the ethnum 1.5.2 E0512 transmute regression, but the file actually ships channel = nightly-2026-05-20 and the lockfile resolves the fixed ethnum 1.5.3. The stale rationale was actively misleading — it sent a downstream consumer (uffs-products) chasing a toolchain downgrade before finding the real fix (bump ethnum, not the channel). Rewrite the block to state reality: current pin 05-20 requires ethnum >= 1.5.3; keep the tokio + ethnum history as *resolved* notes so a future bump does not re-tread it; document that E0512 on a bump is fixed via `cargo update -p ethnum --precise 1.5.3`, never a downgrade. Comment-only change; channel and all settings unchanged. Reported-by: uffs-products OSS sync (docs/OSS_SYNC_FINDINGS.md §1) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the one genuine OSS finding from the
uffs-productssync report (docs/OSS_SYNC_FINDINGS.md§1).rust-toolchain.toml's comment block claimed the channel must stay pinned atnightly-2026-04-17to avoid theethnum 1.5.2E0512 transmute regression — but the file actually shipschannel = "nightly-2026-05-20"(since v0.5.102, commitd4e40baa2) and the workspaceCargo.lockresolves the fixedethnum 1.5.3. The comment was stale and actively misleading.Real-world cost: it sent the products repo chasing a toolchain downgrade before they found the actual fix (bump ethnum, not the channel).
Change
Comment-only rewrite of the
[toolchain]block:05-20requiresethnum >= 1.5.3, with a verify command.cargo update -p ethnum --precise 1.5.3, never a toolchain downgrade.channeland all other settings are unchanged — this touches comments only.Other findings in the report (validated, no action needed)
rustls-webpki 0.103.13,rand 0.9.4/0.10.1(no vulnerable 0.8.x); Dependabot enabled (dependabot-auto-merge.yml)@nightlyfloat vs pinrustup show(honors the pin) — products-only mistakesetuprecipesetup:inshared.just— no collision🤖 Generated with Claude Code