custom labels#292
Open
pwright wants to merge 4 commits into
Open
Conversation
Member
Author
|
@c-kruse I added the warning about 'internal' here too... but note that this doc is not on the 'cli user' path |
c-kruse
reviewed
Jun 24, 2026
| annotations: | ||
| monitoring.io/scrape: "true" | ||
| data: | ||
| labelSelector: "internal.skupper.io/listener in (my-listener)" |
There was a problem hiding this comment.
It feels kind of rude to throw up a warning about not building automation around the internal labels just before demonstrating a fairly compelling reason to do so 😄. I don't know what to do about that, though. This is something a user has specifically asked us to make possible, and in doing so we changed the semantics of the internal.skupper.io/listener label. Maybe a more tempered warning?
Member
Author
There was a problem hiding this comment.
Yep, understood. I've updated note, wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.