JAIPilot campaign evaluation: Spring Integration #11353 - #1
Open
skrcode wants to merge 1 commit into
Open
Conversation
Fixes: spring-projects#11352 cleanUpFileState() discarded every IOException, including the one raised by closing the buffered writer or stream. close() is where the buffer is flushed, so a full disk was reported as a successful write and the truncated temporary file was still promoted onto the result file. Let cleanUpFileState() propagate, and call it on the success path where the caller can see the failure. On the failure path the close error is attached as a suppressed exception instead, so the exception already on its way out is not masked. clearState() still runs either way and the APPEND_NO_FLUSH branch is untouched. Signed-off-by: Jiwoo Lee <dlwldn30@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact cloud-only evaluation mirror of spring-projects#11353
Exact upstream head: 84ab875
JAIPilot must return at most one small, behavior-preserving, independently provable companion draft or leave this PR unchanged. No repository build is being run on a developer laptop.