Skip to content

Don't rebuild when running tests#236

Merged
marcprux merged 1 commit intoskiptools:mainfrom
dfabulich:skip-test-no-prebuild
Apr 26, 2026
Merged

Don't rebuild when running tests#236
marcprux merged 1 commit intoskiptools:mainfrom
dfabulich:skip-test-no-prebuild

Conversation

@dfabulich
Copy link
Copy Markdown
Contributor

skip test was running swift build followed by swift test.

For some reason, swift test assumes that the build has to rerun from scratch with the flags that we're passing, so the swift build was a complete waste. (This doesn't happen when you just swift build --build-tests followed by swift test … the --xunit-output seems to be triggering it.)

Anyway, pre-building is a waste of time regardless, even if it's just a 10ms freshness check. This PR removes the pre-build step, letting swift test run the build.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@cla-bot cla-bot Bot added the cla-signed label Apr 20, 2026
@marcprux marcprux merged commit 93973a1 into skiptools:main Apr 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants