Prepare XCGradleHarness for NonisolatedNonsendingByDefault#676
Open
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Open
Prepare XCGradleHarness for NonisolatedNonsendingByDefault#676dfabulich wants to merge 1 commit intoskiptools:mainfrom
XCGradleHarness for NonisolatedNonsendingByDefault#676dfabulich wants to merge 1 commit intoskiptools:mainfrom
Conversation
Fixes skiptools#675 The issue occurred because the `skip` project is built without `NonisolatedNonsendingByDefault`, which means that `runGradleTests` and `invokeGradle` were `@concurrent` by legacy default, forbidden to access `self` or any `task-isolated` members. The generated `XCSkipTests` file in the end-user's project, however, _is_ `NonisolatedNonsendingByDefault` on Swift 6.2, which means that `testSkipModule` method became task-isolated. (I'm a little unclear on how/why the test became task-isolated, but it did.) We could have fixed this by updating `skip` to Swift 6.2+ and enabling `NonisolatedNonsendingByDefault` and other "Approachable Concurrency" features there, but this is easier, and will continue to work if/when we upgrade `skip` in the future. (When `skip` does decide to enable `NonisolatedNonsendingByDefault`, these annotations will simply reiterate the default.)
cla-bot
Bot
added
the
cla-signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #675
The issue occurred because the
skipproject is built withoutNonisolatedNonsendingByDefault, which means thatrunGradleTestsandinvokeGradlewere@concurrentby legacy default, forbidden to accessselfor anytask-isolatedmembers.The generated
XCSkipTestsfile in the end-user's project, however, isNonisolatedNonsendingByDefaulton Swift 6.2, which means thattestSkipModulemethod became task-isolated. (I'm a little unclear on how/why the test became task-isolated, but it did.)We could have fixed this by updating
skipto Swift 6.2+ and enablingNonisolatedNonsendingByDefaultand other "Approachable Concurrency" features there, but this is easier, and will continue to work if/when we upgradeskipin the future. (Whenskipdoes decide to enableNonisolatedNonsendingByDefault, these annotations will simply reiterate the default.)Skip Pull Request Checklist:
swift test