Access CoreLocation dynamically instead of importing it directly#35
Merged
Conversation
marcprux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30. As described there, the mere act of using SkipKit is enough to trigger scary App Store Connect warnings and emails about needing to declare location usage description keys in the Info.plist. SkipKit doesn't actually use your location itself, it merely imports CoreLocation to be able to provide a unified PermissionManager API to check for various permissions.
This PR makes it so we don't import (and thereby implicitly link to) CoreLocation, and so we should be able to depend on SkipKit without having the declare why we might be using location data.