recording: align metafile cursor with parsed metadata bytes#2090
Closed
tombriden wants to merge 1 commit intosipwise:masterfrom
Closed
recording: align metafile cursor with parsed metadata bytes#2090tombriden wants to merge 1 commit intosipwise:masterfrom
tombriden wants to merge 1 commit intosipwise:masterfrom
Conversation
since previous change relating to incomplete metafile's being read while still being written, there are still circumstances that result in failure This change tracks last_good_pos after each full section and advances mf->pos once by parsed buffer prefix so the next read does not skip tail bytes. The log lines have now been made dbg instead of warnings as they should be handled correctly on subsequent reads of the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since previous change relating to incomplete metafile's being read while still being written, there are still circumstances that result in failure
This change tracks last_good_pos after each full section and advances mf->pos once by parsed buffer prefix so the next read does not skip tail bytes. The log lines have now been made dbg instead of warnings as they should be handled correctly on subsequent reads of the file