Repository navigation
Conversation
- ucl_state_machine(): the object returned by ucl_parse_macro_arguments()
was leaked when skipping comments after the arguments failed (e.g.
unterminated comment) or when ucl_parse_macro_value() failed.
- ucl_parser_free(): lower-priority duplicate objects parked in
trash_objs can still acquire nested containers while parsing continues
(e.g. ".priority 6\n\x92 a\n.priority 2\n\x92 a {"); they were freed
with the shallow ucl_object_dtor_free, leaking the nested containers.
Use ucl_object_dtor_unref so children are released too.
Found by rtpproxy's fuzz_config_file fuzzer (LeakSanitizer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two LeakSanitizer findings from rtpproxy's new config fuzzer (sippy/rtpproxy#183):
Opened to run CI (workflows only trigger on master push/PR).