Skip to content

Conversation

@Arapak
Copy link
Contributor

@Arapak Arapak commented Dec 10, 2025

Updated filetracker’s Python version from 3.8 to 3.13. Upgrading Gunicorn from 19.9.0 to 23.0.0 required adjusting the logging configuration, as outlined here: benoitc/gunicorn#2250

Gunicorn commit that introduced the logging change:
benoitc/gunicorn@6da84c6

@Arapak Arapak marked this pull request as ready for review December 10, 2025 17:28
@Arapak Arapak requested a review from Wolf480pl as a code owner December 10, 2025 17:28
@Wolf480pl
Copy link
Member

Why did I get assigned as reviewer for this one and not @twalen ? 🤔

@Wolf480pl Wolf480pl requested review from twalen and removed request for twalen December 10, 2025 20:18
Copy link
Member

@Wolf480pl Wolf480pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite out of the loop with sio, and not really sure if this update to 3.13 is correct.
If @twalen is unable to approve it for some reason (eg. CODEOWNERS behaving in a weird way), I can click the "approve" button, but don't count this as a proper review.

@twalen
Copy link
Contributor

twalen commented Dec 10, 2025

I'm quite out of the loop with sio, and not really sure if this update to 3.13 is correct. If @twalen is unable to approve it for some reason (eg. CODEOWNERS behaving in a weird way), I can click the "approve" button, but don't count this as a proper review.

I'm on this PR. The email about review was automatically generated by github since you are in CODEOWNERS.

Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@twalen twalen merged commit 92e65f4 into master Dec 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants