Conversation
perlowja
force-pushed
the
feat/wallpaper-attribution-quadrant
branch
2 times, most recently
from
September 18, 2026 20:14
5807ef3 to
4548ba4
Compare
Contributor
Author
|
@mirkobrombin gentle bump on this one when you have a moment - would love your thoughts on the attribution quadrant picker. |
Member
|
Top positions end up under the panel: the background covers the whole screen (exclusive zone -1) and the label never gets |
Contributor
Author
|
@mirkobrombin this one's been open a week with CI green and no conflicts against main -- could you take a look when you have a chance? |
perlowja
force-pushed
the
feat/wallpaper-attribution-quadrant
branch
from
September 27, 2026 14:24
4548ba4 to
46fcb42
Compare
Extends the wallpaper title/author overlay from a fixed bottom-left position to a user-selected quadrant (top-left, top-right, bottom-left, bottom-right), exposed as a Settings row below the existing visibility toggle. An invalid or unset value safely falls back to bottom-left, matching the previous fixed behavior. The contrast-sampling rect (corner_luminance_frac call in update_attribution()) now tracks the active quadrant too -- it previously always sampled the bottom-left corner of the wallpaper regardless of where the label actually sat, which would have picked light/dark text against the wrong part of the image for any non-bottom-left placement. Needs the wallpaper-attribution-position schema key (singularityos-lab/singularity-desktop#262). This ports and extends a working left/right-only version the operator had running locally (never previously upstreamed) to the full 4-quadrant case the current design calls for. contrast-sample rect to track the active quadrant, added the Settings picker row. Assisted-by: Claude Code:claude-sonnet-5 AI-Scope: Ported and extended prior left/right attribution-position vala logic to full 4-quadrant support, plus fixed the contrast-sample rect to track the active quadrant.
Move top-positioned wallpaper attribution below the panel using the panel height tracked by AppSystem, while retaining the existing edge gutter. Make the position row insensitive whenever wallpaper attribution is disabled. Assisted-by: Codex:gpt-5.6-sol AI-Scope: Fixed top attribution placement to clear the panel and bound the position row sensitivity to the attribution setting.
perlowja
force-pushed
the
feat/wallpaper-attribution-quadrant
branch
from
September 29, 2026 18:03
46fcb42 to
c55c4f2
Compare
Contributor
Author
|
@mirkobrombin both points from your review are fixed in c55c4f2 (rebased on main 3b72f26):
Built on main with desktop#262 and plugins#2 on forky arm64: ninja 379/379 targets, meson test 23/23 pass. The AI trailers now name the tool and model per commit. Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the wallpaper title/author overlay from a fixed bottom-left position to a user-selected quadrant (top-left, top-right, bottom-left, bottom-right), via a Settings row below the existing visibility toggle. Depends on singularityos-lab/singularity-desktop#262 for the
wallpaper-attribution-positionschema key.An invalid/unset value falls back to bottom-left, matching current behavior -- this PR changes no default.
Real bug fixed along the way: the contrast-sampling rect (
corner_luminance_fraccall) always sampled the bottom-left corner of the wallpaper regardless of where the label actually renders. Extending to 4 quadrants without fixing this would have picked light/dark caption text against the wrong part of the image for top or right placements. The sample rect now mirrors to match the active quadrant.This ports and extends a working left/right-only version to the full 4-quadrant case.
Verified: full
ninja -C builddirbuild succeeds (0 errors, only pre-existing unrelated warnings) against a fresh subproject checkout of libsingularity + singularity-loginui.Assisted-by: Claude Code:claude-sonnet-5
AI scope: extended halign/valign switch to 4 quadrants, fixed the contrast-sample rect to track the active quadrant, added the Settings picker row.
AI assistance: disclosed