Conversation
perlowja
force-pushed
the
feat/bing-preferred-market-picker
branch
2 times, most recently
from
September 18, 2026 20:15
2dabaa1 to
e395533
Compare
Author
|
@mirkobrombin bumping this one too - restores the preferred-region picker for the Bing wallpaper source. |
Member
|
Singularity must stay distro-agnostic: the plugin shouldn't write another distro's config ( |
Adds a Bing Preferred Region SelectionRow to get_settings_widget() -- 14 options (All Markets, No Preference, plus 13 individual markets labelled Region - Market), reading/writing ~/.config/ncz-wallpaper/bing-markets, the same file cix-installer's 45-wallpaper-rotator.sh ncz-wallpaper-bing helper already reads. Ports a complete, working implementation (fa5a38a on singularity-shell, zoder-reviewed, full ninja+meson test pass) that lived inline on the Desktop settings page before the plugin-based wallpaper manager (132efb7) deleted it as collateral damage of that rewrite -- it never had a new home in the plugin architecture. Every market is always fetched and combined by the helper regardless of this setting; the picker only chooses whose caption/credit wins when the same photo is shared across regions. Verified: full ninja -C builddir build succeeds (0 errors) against a fresh subproject checkout of libsingularity. plugin's settings widget, adjusted class/field placement for the plugin context. Assisted-by: Claude Code:claude-sonnet-5 AI-Scope: Recovered and ported the pre-deletion 320-line Bing preferred-market SelectionRow picker (from before upstream commit 132efb7 removed it) into the new wallpapers-bing plugin's settings widget.
Assisted-by: Codex:gpt-5.6-sol AI-Scope: Updated the Bing market picker to load and persist settings through the wallpaper helper.
perlowja
force-pushed
the
feat/bing-preferred-market-picker
branch
from
September 30, 2026 00:22
0900713 to
d1ef213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Bing Preferred Region SelectionRow to the wallpapers-bing plugin settings.
The picker obtains available markets from the helper, reads the current preference through the helper, and delegates preference updates to the helper without accessing distro-specific configuration files.
Verified by building wallpapers-bing/libwallpapers-bing.so with Meson and Ninja in a Debian trixie container against the current libsingularity fallback.
AI assistance: disclosed