Open
Conversation
ulysse-bouchet
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce DockerMode enum in docker.rs to distinguish between running run_aster and starting an interactive shell
Refactor docker_aster to accept a
DockerModeparameter instead of separate export_file/args parametersAdd shell_aster function in manage.rs that launches an interactive bash shell inside the container
Add cave shell CLI subcommand wired to shell_aster
Motivation
Previously docker_aster always built and executed a run_aster command, making it impossible to reuse for interactive shell sessions. This refactor cleanly separates the two use cases while keeping all Docker container setup (volume mount, user permissions, image selection) in a single function.
Test plan
cave run -- my_study.exportstill executes correctly and telemetry is sentcave shelldrops into an interactive bash shell inside the container-cave shellwith no version set in .cave returns aVersionNotInstallederrorcave shellwith a version not pulled locally returns aVersionNotInstallederror