-
Notifications
You must be signed in to change notification settings - Fork 739
Generalized Profileset Control #10685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renanthera
wants to merge
21
commits into
simulationcraft:thewarwithin
Choose a base branch
from
renanthera:sim_controllers
base: thewarwithin
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Generalized Profileset Control #10685
renanthera
wants to merge
21
commits into
simulationcraft:thewarwithin
from
renanthera:sim_controllers
+762
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:combat()` gets called once. This causes all actions to be constructed, fixing the warning.
…s, move implementation out of `sim_t` and improve reporting.
…point at which a controller causes a profileset to bail out, as well as reason.
… clarify ownership.
Member
Author
|
Still researching best practices for statistical methods required to implement profileset culling in the most optimal/correct way. The rest of the implementation is otherwise functional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from the concept found in #10597, but generalized to allow for custom implementation in class modules.
Significant outstanding issues:
profileset_controller_t::evaluate_*calls, as they only return sensible values during iteration runtime. Checking whether or not a player has a sufficient amount of a secondary stat, etc, is impossible as a result.TODO:
Developer interface issues:
profileset_controller_trequires ausing data_t = <derived from profileset_controller_data_t>;type alias. Every controller probably should get and set a derivedprofileset_controller_data_t, just for the sake of reporting, as it is otherwise impossible to customize.profileset_controller_t::get_data<T>()andprofileset_controller_t::set_data<T>(...)require a template parameter which is always equal to the type-aliaseddata_tfor the derivedprofileset_controller_t. This kind of sucks, but I'm not sure of a way to avoid this without introducing manual mutex management and gratuitous casting.Notes:
profileset_controller_t::create_options()is kind of awful if the option value type isn't well supported.