Skip to content

fix(chat): name stackless error subclasses and compact stored unfinished tool params - #8928

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/v0919-review-followups
Oct 12, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/v0919-review-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Function errors: recognize Node's stackless [Class [name]: message] headline (an error subclass that keeps its parent's name), so it reports the thrown error instead of falling back to Execution failed. Names match the stacked form (QuotaExceeded [Error])
  • Chat transcript: stored assistant turns now compact params of unfinished tool calls too — they render as interrupted and are never re-run or approved. Only the live assistant message keeps unfinished params whole
  • One shared isStoredAssistantMessage predicate for display and compaction so the two can't drift

Type of Change

  • Bug fix

Testing

  • code-failure.test.ts and lib/mothership/chat/** tests pass (559); new cases fail on the pre-fix code
  • Real Node 22 / Python stderr harness: 5 of 61 cases improve (all previously Execution failed), the rest unchanged; non-error bracket forms ([Object: …], [Function: …], [class A [T]]) still don't match
  • biome on changed files; type-check and audits in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR recognizes Node's stackless error subclass headlines and shortens long tool params in stored assistant turns.

  • Stackless Node errors keep the subclass name they were thrown with.
  • Stored unfinished tool calls show shorter params, while live calls keep full params.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Assistant message] --> B{Stored message?}
  B -->|Yes| C[Compact long tool params]
  C --> D[Show unfinished calls as interrupted]
  B -->|No| E{Unfinished call?}
  E -->|Yes| F[Keep full params]
  E -->|No| C
Loading

Reviews (1) · Last reviewed commit: "fix(chat): name stackless error subclass..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 12a321a into staging Oct 12, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/v0919-review-followups branch October 12, 2026 17:59
@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 12, 2026 6:45pm UTC

Request Review

This branch was previously deployed

1 inactive deployment
Preview — 9efd683c Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant