Skip to content

improvement(app): show branded wordmark while loading - #8879

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/branded-refresh-loader
Oct 10, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/branded-refresh-loader

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Show the canonical muted Sim wordmark while the application shell loads, using the existing light and dark theme tokens without adding animation or a minimum delay.
  • Replace the workspace entry and workflow navigation spinners with the same loading surface. Preserve desktop title-bar dragging, custom branding, and existing error and empty states.
  • Start workspace data and authorized branding reads in parallel; show the correctly branded loading screen while retaining the shared query cache and provider hierarchy.

Type of Change

  • Improvement

Testing

  • Real local app and disposable PostgreSQL: hard refresh in light/dark themes, centered geometry, loading-to-ready transition, and subsequent Files navigation. Screenshots and JSON reports captured.
  • HTTP streaming checks held sidebar reads in a database transaction: both Sim and custom-branded workspaces showed their loading surface before data was released. Signed-out and denied-workspace paths retained their existing behavior. Removing the fallback made the streaming checks fail; restoring it passed.
  • Delayed-read HTTP verification reproduced serialized branding/sidebar reads before the review fix and concurrent starts after it. Custom branding, loading-to-ready completion, and access checks passed.
  • Existing layout tests updated to await streaming completion; 13 adjacent tests passed. Full root tests, all 26 workspace type checks, 58 audits, lint, generators, block registry, docs manifest, and pinned actionlint passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 10, 2026 3:37am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/app/workspace/[workspaceId]/layout.tsx Outdated
@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

The PR replaces application loading spinners with a shared, theme-aware wordmark and preserves custom workspace branding.

  • App entry and workflow waits show the same centered brand mark.
  • Authorized workspace pages show their host brand while the shell loads.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Check session] --> B[Resolve authorized workspace]
  B -->|Denied| C[Access denied]
  B -->|Allowed| D[Start branding read]
  D --> E[Loading screen waits for branding]
  D --> F[Workspace reads run alongside branding]
  E --> G[Show branded wordmark]
  F --> H[Render workspace with shared cache and branding]
Loading

Reviews (2) · Last reviewed commit: "fix(app): preload workspace data alongsi..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 20101c5 into staging Oct 10, 2026
42 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/branded-refresh-loader branch October 10, 2026 03:44

This branch was previously deployed

1 inactive deployment
Preview — 2f513218 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant