Repository navigation
fix(desktop): read tmux format output with a separator no tmux version escapes - #8720
Merged
Merged
Conversation
…n escapes tmux 3.4 and 3.5 print control characters in -F output as octal escapes, so the 0x1f field separator arrived as the text \037 and no line split: Sim never found the tmux client in a terminal, treated it as a plain shell, and the panes operation came back empty. The separator is now printable text that no tmux escapes; a field that happened to contain it changes the line's field count, so that line is dropped rather than misread. The fake tmux in the unit tests now escapes its output the way 3.4 and 3.5 do, so this cannot pass unnoticed again.
Collaborator
Author
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Foutput with a0x1fbyte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four characters\037and no line split.panesoperation came back empty.|~sim~|, which no tmux version escapes. A field that happens to contain it changes the line's field count, so that line is dropped rather than misread.Why not accept both forms
\prints as\\).\037" could cut a field whose text holds a real\037.Versions checked (real binaries)
0x1fseparator|~sim~|separator\037\037On real tmux 3.4,
listPanesreturned nothing with staging's code and the session's panes with this change.Autopsy
Type of Change
Testing
Checklist